Closed
Bug 936625
Opened 12 years ago
Closed 12 years ago
responseserializer should save country
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=user c=submission p=1 s=input.2013q4)
FirefoxOS web form uses the Input API to save data. However, the ResponseSerializer isn't saving the country, so we're not saving that data in the db.
This bug covers fixing the ResponseSerializer to capture the country.
|
Assignee | |
Comment 1•12 years ago
|
||
Grabbing this one.
Pretty sure the problem is here:
https://github.com/mozilla/fjord/blob/master/fjord/feedback/models.py#L181
"country" should be added to the list of fields and also to the list of things saved in the Response object.
Further, we should add a test and add this to the docs for the API.
Assignee: nobody → willkg
|
|
Assignee | |
Comment 2•12 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/170
Landed in master in: https://github.com/mozilla/fjord/commit/2abca90
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed to production just now.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•12 years ago
|
||
This was a quick fix. Making it 1 point.
Whiteboard: u=user c=submission p= s=input.2013q4 → u=user c=submission p=1 s=input.2013q4
|
||
Updated•9 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•