93827 - Print module autoselection could be better...

Status: VERIFIED FIXED

(Core :: Printing: Output, enhancement)

Description

[Roland Mainz]

Unix print module autoselection could be better. 
Currently the Xprint module is "activated" by setting the XPSERVERLIST env var;
setting |user_pref("print.print_method", 1)| in prefs.js forces Xprint module,
setting |user_pref("print.print_method", 0)| forces the PostScript module.

It would be better to do it this way:
|user_pref("print.print_method", x)|
x=0 : default, use autoselection via XPSERVERLIST
x=1 : use Xprint module
x=2 : use PostScript module
x=3 : use Win32 print API ("reserved" value, not implemented on Unix :-)

More things to fix:
- the code should use |enum|s instead of plain integer values
- "print.print_method" should be documented in unix.js
- |#ifdef USE_POSTSCRIPT| PostScript glue code to implement RFE/bug 80625
partially...

Comment 1

[Roland Mainz]

Reassigning to myself...

Comment 2

[Roland Mainz]

Attachment: patch for 2001-08-05-08-trunk

Comment 3

[Roland Mainz]

Filed patch. Note that this patch fixes crashes when the print device context
cannot initalize for some reason, too.

Requesting r=/sr=

Comment 4

[dcone (gone)]

looks good, make sure to run through tests for the methods you support.
r=dcone.

Comment 5

[Roland Mainz]

dcone:
> looks good, make sure to run through tests for the methods you support.
yup... I tested that... and I'll test that again tonight...

> r=dcone.

thanks!

Comment 6

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 7

[timeless]

fix checked in

Comment 8

[Roland Mainz]

Reopening. 

Unix builds with GTK+ toolkit but without libXp.so do not build (like "worms").
Silly mistake... Patch follows...

Comment 9

[Roland Mainz]

Attachment: bustage fix

Comment 10

[Roland Mainz]

Oh... yes... I forgot to close this one... :-)

Fixed. And works... :-)

sujay, wanna verify, please ?

Comment 11

[sujay]

Roland can you verify this and mark VERIFIED-FIXED ? thanks.

Comment 12

[Roland Mainz]

Tested.... works.
Marking bug as VERIFIED.