940160 - constify the PLDHashTableOps struct in nsTHashtable::Init

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

Because more const is a good thing.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: constify the PLDHashTableOps struct in nsTHashtable::Init

const++ and PL_DHashTableInit already took a const ops structure.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8334289 [details] [diff] [review]
constify the PLDHashTableOps struct in nsTHashtable::Init

Kicking over to ehsan, who has a shorter review queue.

Comment 3

[(no longer active)]

Comment on attachment 8334289 [details] [diff] [review]
constify the PLDHashTableOps struct in nsTHashtable::Init

Review of attachment 8334289 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/nsTHashtable.h
@@ +391,5 @@
>  template<class EntryType>
>  void
>  nsTHashtable<EntryType>::Init(uint32_t aInitSize)
>  {
> +  static const PLDHashTableOps sOps = 

Nit: trailing space :P

Comment 4

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed3e74f6fd4

Comment 5

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/0ed3e74f6fd4