94023 - <EMBED> tags load Java with no reason

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect, P4)

Description

[Daniel Mario Vega (Restore MNG Support --> #18574)]

BuildID:    2001080308

Any page with <EMBED> tag loads Java VM with no reason.

Reproducible: Always
Steps to Reproduce:
o to Any URL with <EMBED> tags
e.g. http://www.novamens.com/

Actual Results:  Java VM gets loaded with no reason

Expected Results:  Java VM should not load

This bug does not occur on Windows

My Java VM is "Java(TM) Plug-in Blackdown-1.3.1-FCS"

Comment 1

[shrirang khanzode]

oji

Comment 2

[edburns]

a

Comment 3

[shrirang khanzode]

SPAM: reassigning all OJI bugs to new OJI QA, pmac ( 227 bugs)

Comment 4

[Vladimir Strigun]

I can reproduce this bug under Linux with Mozilla 0.9.3 
Build: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3) Gecko/20010801
Sun Java plugin version 1.3.1

Comment 5

[edburns]

Ressign to Joe Chou, as I am no longer working officially on OJI.

Comment 6

[Igor Nekrestyanov]

Can not reproduce it with http://www.novamens.com/
but with original URL i saw java console opened as soon as i visited 
that page. Need further investigation. 

Comment 7

[Daniel Mario Vega (Restore MNG Support --> #18574)]

Igor,

I think you could not reproduce the problem with http://www.novamens.com/
because that page has JavaScript code that detects if you have the "Shockwave
Flash" plugin installed on your machine. If you don't have that plugin then you
are redirected to a plain html page. Else you are redirected to a Flash page.

You can try to go to the Flash page directly to reproduce this bug.

http://www.novamens.com/flash/home0.html

Comment 8

[Joe Chou]

Re-assign to laa.

Comment 9

[Igor Nekrestyanov]

Well, i could not reproduce the problem anymore with today's trunk.
It seems it was fixed. 

However, i see different problem - if you cancel attempt to download 
plugin and then try to resize window - then you will be prompted again.
But this is not OJI-specific problem and therefore i suggest to 
file new bug against plugins for this.

reporter: would you please verify whether original problem is 
   actually gone in latest nightly?

Comment 10

[Daniel Mario Vega (Restore MNG Support --> #18574)]

The problem is *not* fixed with BuildID: 2001111314 on Linux
How to reproduce:

1. Close mozilla
2. Open a console terminal and verify that no "java" is running.
      >ps -e | grep java
   No java process should be running.
3. Open mozilla
4. Verify again that no java process is running
      >ps -e | grep java
5. Go to http://edvista.com/claire/qt/embedtags/autoplayfalse.html
   (or any page with <embed> tag)
6. Run again the "ps" command:
      >ps -e | grep java
      1239 pts/3    00:00:01 java_vm
      1240 pts/3    00:00:00 java_vm
      1241 pts/3    00:00:00 java_vm
        :
        :
      1252 pts/3    00:00:00 java_vm

This problem is a Linux (Unix?) only bug. Windows works fine.

Comment 11

[Daniel Mario Vega (Restore MNG Support --> #18574)]

**** top100 keyword because some Top100 sites use Flash or Realplayer plugins.
e.g Macromedia, CNN, etc.

Comment 12

[Igor Nekrestyanov]

Sorry. I forgot that i disabled openning of java console by default.
In fact i can reproduce this.

I did some digging and found out that jvm startup is caused 
by workaround to bug 83698.
See
http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsObjectFrame.cpp#1266

In fact creation of proxyJNI is necessary if we want to startup 
java plugin but not others. 
Explicit check for mime type here (at ObjectFarme) seems to be not the best
idea. 

I will check whether we can move proxyJNI creation to PluginHostImpl
 where we have more freedom dealing with mime types.

Comment 13

[Peter Lubczynski]

You may be able to move it to nsPluginHostImpl::InstantiateEmbededPlugin():
http://lxr.mozilla.org/seamonkey/source/modules/plugin/base/src/nsPluginHostImpl.cpp#3151
..but it may need a little cleanup. I think a better way to check if we are Java
is to QI the plugin instance to a nsIJVMPluginInstance.

Comment 14

[Igor Nekrestyanov]

I will attach patch that fix problem for me.
Basically i reverted fix for 83698 in nsObjectFrame 
 and moved it to nsPluginHostImpl.

peter: we can not QI for nsIJVMPluginInstance because we need to 
   do this before we create actual plugin instance (see 83698 for details)

Could someone review proposed patch?

Comment 15

[Igor Nekrestyanov]

Attachment: Proposed patch

Comment 16

[Peter Lubczynski]

Comment on attachment 57933 [details] [diff] [review]
Proposed patch 

I guess there isn't a better way of checking here for Java than just using the
mime-type. r=peterl

Comment 17

[Igor Nekrestyanov]

Could anybody make sr for proposed patch?

Comment 18

[Patrick C. Beard]

Comment on attachment 57933 [details] [diff] [review]
Proposed patch 

sr=beard

Comment 19

[Andrew A. Lyamov]

Reassigning to Igor.

Comment 20

[Peter Lubczynski]

Patch checked in to the trunk, marking FIXED.

Comment 21

[Daniel Mario Vega (Restore MNG Support --> #18574)]

I verify this bug is fixed in Build ID: 2001113006

Comment 22

[Daniel Mario Vega (Restore MNG Support --> #18574)]

I forgot to say: "Congratulations! Good job!" :-)