946736 - date links in response don't filter dashboard correctly

Status: RESOLVED FIXED

(Input Graveyard :: Dashboard, defect, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The date links for responses don't have correct date_start values, so they don't correctly filter in the dashboard.

STR:

1. go to https://input.mozilla.org/
2. click on the date link for a response. it's humanized text, so it'll be something like "2 minutes ago".

Expected:

1. the dashboard should filter on all responses for that day

Actual:

1. the dashboard ignores the date_start completely and nothing changes

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Two things:

1. I think that link should actually be setting date_start and date_end.

2. The value looks like it's in the form YYYY-MM-DDTHH:MM:SS and it should really just be YYYY-MM-DD. I bet the dashboard view code sees that and ignores it because it's not a valid date.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Throwing it in this quarter because I'm pretty sure I'm right and therefore it's a quick fix.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/196

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/fjord/commit/e16ce46

Waiting to push to production because it's release week.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to prod just now.