94794 - sidebar grippy is at the top (left in mail), should be in middle

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[sujay]

using 8/10 trunk build on Mac

1) launch netscape in classic skin
2) look at sidebar grippy, its all the way at the top. it should
   be in the middle.

Modern is fine. Its in the middle on Modern skin

Comment 1

[Tracy Walker [:tracy]]

It is on modern.  Go to mail.  the grippy is aligned left on the mail pane 
seperator

Comment 2

[Tracy Walker [:tracy]]

*** Bug 94792 has been marked as a duplicate of this bug. ***

Comment 3

[Tracy Walker [:tracy]]

This was not resolved with the fix for bug 93317. 

-The grippies (horizontal and vertical) are not centered in classic skin
-Horizontal grippie( Mail panes)is not centered in modern skin. 

this has been present since build 2001-08-02-04-trunk

Comment 4

[Tracy Walker [:tracy]]

this is now affecting windows and it is present in classic and modern skin.

to see this:

open mail to see a horizontal pane divider.  The grippy is aligned to the left.

Comment 5

[Joe Hewitt (gone)]

mac classic -> andreww

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

As said before, this is not limited to Mac Classic.  This should be re-assigned,
probably to Hyatt.

Comment 7

[sol]

Added regression and nsbranch keywords

Comment 8

[Tracy Walker [:tracy]]

this has recently begun appearing in linux also

Comment 9

[andreww]

Yep. This is due to the alignment changes from hyatt. Looks like mac 
classic was overlooked.

Comment 10

[Mike Young]

this seems like a dup (or related bug) of bug 94180. Apparently they are both,
"Grippies aren't where they are supposed to be."

Comment 11

[Jaime Rodriguez, Jr.]

If this is not a dupe, please have your Manager nsbranch+. This looks like one
we'd like to fix.

Comment 12

[andreww]

Ok I found out what is wrong and what to fix about mac classic skin. it will 
behave identical to modern after this patch. This is NOT a dupe of Hyatt's 
bug though because even after I fixed this on my tree I still get the H-bar 
left aligned till I clicked on it.   Just like modern (Also Just like Toy Factory 
too)

Comment 13

[hangas]

marking + and 0.9.5

Comment 14

[andreww]

Attachment: diffs for fixing splitters in mac classic.

Comment 15

[andreww]

Attachment: updated diff for classicBindings.xml

Comment 16

[Joe Hewitt (gone)]

sr=hewitt

Comment 17

[Jaime Rodriguez, Jr.]

Who else can review this, so we can get moving on it?

Comment 18

[andreww]

seeking review now

Comment 19

[Håkan Waara]

sure, r=hwaara.

Comment 20

[Jaime Rodriguez, Jr.]

dOES THE LAST PATCH HAVE BOTH An r= and sr=?

Comment 21

[Håkan Waara]

Jaimejr: Yes, sr=hewitt, r=hwaara.

Comment 22

[andreww]

PDT - please consider letting this in. It's a very easy patch and fixes a 
most egregious error in mac classic skin.   

Comment 23

[Jaime Rodriguez, Jr.]

check it in - PDT+

Comment 24

[andreww]

ok checked into branch. 

Will check into trunk asap.

Comment 25

[sujay]

verified in 9/26 branch.

will verify on trunk after it is fixed there or when this bug is marked
RESOLVED-FIXED.

Comment 26

[andreww]

checked into trunk. marking FIXED.

Comment 27

[Tracy Walker [:tracy]]

verified fixed on mac commercial builds: 
mac 2001-09-27-03-0.9.4
mac 2001-09-27-04-trunk