94834 - libimg fail build if --without-png and --without-mng is NOT specified buring configure

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Pawel Worach]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3+) Gecko/20010811
BuildID:    20010811

the PNGDIR and MNGDIR variables are not set by configure if
--without-png and --without-mng is specified.

the makefile starts a for loop for each subdir but subdir is enpty and for
failes with unexpected ";" (for d in ; ...)

subdirs should be tested for "" and the loop skipped if empty, we will then use
the native libpng and libmng libs or better PNGDIR=png and MNGDIR=mng shound be
set as default values by configure...

Reproducible: Always
Steps to Reproduce:
1. ./configure --prefix=/opt/mozilla --disable-tests --disable-debug
--enable-optimize 
2. gmake
3. failes in modules/libimg

Actual Results:  /bin/sh: -c: line 1: syntax error near unexpected token `;'
/bin/sh: -c: line 1: `set -e;  for d in  ; do sed -e "s!Y!export......


Expected Results:  LIBPNG and LIBMNG should not be "" or loop should not be
executed if LIBPNG and LIBMNG is null

Linux distro is Redhat 7.1.93 (Roswell beta)
i guess PC/Linux is not the only platform...

Comment 1

[cls]

Pavlov, more libimg1 clean up.  DIRS should never be set to an empty string.

Comment 2

[Pawel Worach]

Attachment: Fix? (very very ugly but WorksForMe(tm))

Comment 3

[Takanori MATSUURA]

On my machine (Linux PPC), same situation is occured and is fixed by the
attachment #45498 [details] [diff] [review].

Comment 4

[Axel Hecht]

How about this (upcoming) diff? It's smaller, and should fix it. (can't test, 
it doesn't happen on my box.)

Axel

Comment 5

[Axel Hecht]

Attachment: move from make vars to DIRS +=, DIRS should stay undefined for neither mng nor png

Comment 6

[Lawrence Walton]

patch (id=46738) fixes this for me. 
Thanks Pike you rock. :)

Comment 7

[tor]

*** Bug 96948 has been marked as a duplicate of this bug. ***

Comment 8

[Stuart Parmenter]

Comment on attachment 46738 [details] [diff] [review]
move from make vars to DIRS +=, DIRS should stay undefined for neither mng nor png

r=pavlov

Comment 9

[Johnny Stenback (:jst)]

sr=jst

Comment 10

[Axel Hecht]

fix is in. gonna ask drivers if they want that in 0.9.4.

Axel

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 46738 [details] [diff] [review]
move from make vars to DIRS +=, DIRS should stay undefined for neither mng nor png

a=asa for checkin to 0.9.4

Comment 12

[Axel Hecht]

checked in on 0.9.4 branch

Comment 13

[Tracy Walker [:tracy]]

verified