94938 - Animated image prefs don't apply to background images

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Blake Ross]

...as a result of the imglib1 removal.

Comment 1

[Akkana Peck]

Any updates on when this regression is going to be fixed?  Seems like it works
in some places, but not in others (e.g. I see flames animating on Tinderbox).

Comment 2

[Blake Ross]

It just doesn't work for animated background images.

Comment 3

[Jaime Rodriguez, Jr.]

Pav/Gagan - Any word on this one? Should we nsbranch+ this one?

Comment 4

[Stuart Parmenter]

Perhaps... is the pref a public pref?  if not, then we probably shouldn't..
however I would like to fix this shortly.

Comment 5

[Stuart Parmenter]

marking - for now, but accepting P3 for 0.9.5

Comment 6

[Akkana Peck]

The pref is indeed exposed in the pref UI: Privacy/Images/Animated Images.

Comment 7

[Stuart Parmenter]

.

Comment 8

[Gilles Durys]

*** Bug 114382 has been marked as a duplicate of this bug. ***

Comment 9

[Jaime Rodriguez, Jr.]

nominating ...

Comment 10

[Jaime Rodriguez, Jr.]

Removing nsbeta1 nomination because this bug has been plussed.

Comment 11

[Nivedita (gone)]

Attachment: patch file for fixing the animated image prefs to background images

The preferences were not fetched for the animated images being set as
background. 

Setting the preferences of animate mode for the background image.

Comment 12

[Nivedita (gone)]

.

Comment 13

[Stuart Parmenter]

Comment on attachment 73641 [details] [diff] [review]
patch file for fixing the animated image prefs to background images

r=pavlov

Comment 14

[tor]

Does this mean that the nsImageFrame animation mode setup
is no longer needed?

Comment 15

[Nivedita (gone)]

We still need nsImageFrame animation mode setup, for the images which are not 
back ground images. 

We do not hit the nsImageFrame path for the back ground images. nsImageLoader 
takes care loading  of the background images. Hence, even though the prefs 
check was present in nsImageFrame, the background images were not getting 
reflected by the prefs. And as the comment 1 says that it works in some places, 
but not in others. Hence without this patch, the background images would not 
get reflected with the update in preferences.

Comment 16

[tor]

Comment on attachment 73641 [details] [diff] [review]
patch file for fixing the animated image prefs to background images

sr=tor

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 73641 [details] [diff] [review]
patch file for fixing the animated image prefs to background images

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 18

[Nivedita (gone)]

Fixed with the checkin 
D:\testing_cvs\mozilla\layout\base\src>cvs commit
cvs commit: Examining .
? out
Checking in nsImageLoader.cpp;
/cvsroot/mozilla/layout/base/src/nsImageLoader.cpp,v  <--  nsImageLoader.cpp
new revision: 3.6.4.1; previous revision: 3.6
done

Comment 19

[Bradley Baetz (:bbaetz)]

You checked this into the 0.9.9 branch, according to bonsai.

Reopening.

Comment 20

[Vinay Badami]

Really checking into the tip
D:\mozilla\layout\base\src>cvs commit nsImageLoader.cpp
Checking in nsImageLoader.cpp;
/cvsroot/mozilla/layout/base/src/nsImageLoader.cpp,v  <--  nsImageLoader.cpp
new revision: 3.9; previous revision: 3.8
done

Comment 21

[Nivedita (gone)]

undone the changes in the 0.9.9 branch. Sorry for the messing up.

D:\testing_cvs\mozilla\layout\base\src>cvs commit nsImageLoader.cpp
Checking in nsImageLoader.cpp;
/cvsroot/mozilla/layout/base/src/nsImageLoader.cpp,v  <--  nsImageLoader.cpp
new revision: 3.6.4.2; previous revision: 3.6.4.1
done

Comment 22

[Terri Preston]

Verified fixed Win XP branch (2002042306) win 2k trunk (2002042303) Mac OS X
trunk (2002042203) Mac OS X branch(2002042205) and linux branch (2002042208) and
linux trunk (2002042210), marking verified