952100 - DevTools Themes: Style toolbar buttons

Status: RESOLVED DUPLICATE of bug 942292

(DevTools :: General, defect)

Description

[Brian Grinstead [:bgrins]]

Some buttons in the new theme can be seen at https://people.mozilla.org/~shorlander/mockups/devTools/ux-refresh-2013/[e-mail] and https://people.mozilla.org/~shorlander/mockups/devTools/ux-refresh-2013/[e-mail].

Comment 1

[Brian Grinstead [:bgrins]]

Darrin,
Can you provide designs showing the different states (such as normal / hover / active / checked / anything else) for these buttons?

Comment 2

[Girish Sharma [:Optimizer]]

I think we need to clearly call out that there are two varieties of buttons used in our devtools:

1) With icons (even the pretty print button is considered as icon button)
2) With text (The console filtering buttons)

While the refreshed mockups at  https://people.mozilla.org/~shorlander/mockups/devTools/ux-refresh-2013/ clearly define the checked and unchecked styling of the second type of buttons, there is no indication of the styling of icon buttons when the toolbar height is very small.

Should we make the icon buttons rectangular and still have some margin on top and bottom like the text buttons ?

or..

We make the icon buttons on the toolbar look/behave exactly like the gcli buttons on the tabs toolbar (responsive design, split console etc.)

(I am biased towards the second option)

Comment 3

[Brian Grinstead [:bgrins]]

This is the main remaining blocker for the 'paddingless' toolbars, Bug 942292

Comment 4

[Darrin Henein [:darrin]]

Added mockup to https://bugzilla.mozilla.org/show_bug.cgi?id=942292.

Comment 5

[Brian Grinstead [:bgrins]]

Going to handle this in Bug 942292, since this and the paddingless toolbars are destined to be together