95258 - Need to add a new extension to support Complex Text Layout

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Prabhat Hegde]

hi leaf,

We would like to have an extension to support rendering of Scripts
such as Thai and Indic on Unix platforms. This will involve building
of ctl extension (in mozilla/extensions/ctl) by any unix implementation
that would like CTL thai support. 

Please see bug #84380 for more details.

Am attaching the configure, Makefile diffs to build this extension in a
non-default manner.

the patch minimizes/eliminates any risk whatsoever of thai ctl rendering 
code affecting any non-unix, non-intended platforms.

It is expected to be enabled using configure option :
--with-extensions=default,ctl.

In addition the hook that uses this piece of code will be enabled only 
under --enable-ctl.

This means that a *nix build that needs to generate thai presentation 
forms before rendering needs to :

use : configure --with-extensions=default,ctl --enable-ctl <other options>

Unix builds that do not use the above mentioned flags are not expected to
be affected in any way.

Please review the diffs and let me know if you have any issues.

prabhat.

Comment 1

[Prabhat Hegde]

Attachment: A diff file with patch for enabling building of CTL extension

Comment 2

[cls]

Does anything in extensions/ctl require headers or anything from intl/ctl ? 
This patch will allow extensions/ctl to be built when --with-extensions=all is
specified but --enable-ctl is not. 

Also, make sure that the description of the --enable-ctl option lines up with
the rest of the ./configure --help output.  I think it's the 27th column.  And
please submit future patches in unified format (cvs diff -u).

Comment 3

[Jon Granrose]

this looks like what you've been asking leaf about so cc'ing him here.

Comment 4

[Prabhat Hegde]

extensions/ctl has no dependency on private headers from intl/* or any other 
mozilla module.

Will also take care of description for --enable-ctl.

thanks,
prabhat.

Comment 5

[Daniel (Leaf) Nunes]

is it ok to add extension options outside of --with-extensions? This means there
will be two ways of having the ctl directory built, only one of which will do
the right thing as far as defining SUNCTL.

prabhat, can you repost the patch with -u, for those of us who are feebleminded?

Comment 6

[Prabhat Hegde]

have attached the new diff. 

Also thanks for the feedback - have set it up so that ctl extension gets
picked up whenever --enable-ctl is provided, ie way to build would be
configure --enable-ctl <other options>

Comment 7

[Prabhat Hegde]

Attachment: diff -u of the changes

Comment 8

[Daniel (Leaf) Nunes]

r=leaf for the build system changes.

Comment 9

[Prabhat Hegde]

presume i need a sr= to checkin; chris, could you do the needful? I've 
already posted a review request 

thanks,
prabhat.

Comment 10

[cls]

Does the ctl extension do anything without the intl hooks?  I'm trying to figure
out why we'd have the building the hooks automatically invoke the extension but
we  can build the extension at anytime without the hooks.  

Comment 11

[Prabhat Hegde]

Ctl extension in this (first) phase will be used via gfx/nsFontMetrics (Hook
described in #84394). In the next phase which involves layout changes, ctl
extension is intended to be used independantly of intl* or gfx.

prabhat

Comment 12

[cls]

sr=cls on the build changes

Comment 13

[Roland Mainz]

Is it possible to patch nsFontMetricsXlib.[cpp|h], too ? It is nearly identical
to the GTK+ version except the minor differences between GDK/GTK+ and plain X11
API ... thanks!

Comment 14

[Prabhat Hegde]

Attachment: Patch update to reflect latest versions of files before checkin

Comment 15

[Prabhat Hegde]

hi masaki,

Could you please checkin for me as i don't have checkin permissions yet.

thanks,
prabhat.

Comment 16

[Masaki Katakai]

patch checked in for Prabhat.
Please mark this as FIXED.

Comment 17

[cls]

Marking fixed.