Closed Bug 95297 Opened 24 years ago Closed 24 years ago

session history doesn't restore scroll position and form controls

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: hgelman, Assigned: kinmoz)

References

Details

(Keywords: dataloss, smoketest)

In older builds, you used to be able to be scrolled, say, halfway down a page, click on a link, and then click the back button and you'd be back at the location on the previous page where the link was (e.g., halfway down the page.) Now (2001081403, Win95) I wind up at the top of the previous page each time. A good example is a bugzilla bug list. Click on a bug that's not at the top of the page, then click the back button (or alt-left arrow), and you'll be taken to the top of the bug list again, rather than where you were before you clicked the link.
Confirming. All/All. Session history seems to have stopped working. Form control states and scroll positions are no longer remembered.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 95 → All
Hardware: PC → All
Summary: Back button goes to top of previous page, not last position → session history stopped working (scroll position and form control memory)
Summary: session history stopped working (scroll position and form control memory) → session history doesn't restore scroll position and form controls
*** Bug 95326 has been marked as a duplicate of this bug. ***
This causes dataloss when working in bugzilla, as noted in the duplicate. Smoketest blocker for tomorrow (as was the duplicate).
Severity: major → blocker
Keywords: dataloss, nsdogfood, smoketest
This regressed between 2001-08-13-08-trunk and 2001-08-13-21-trunk builds (tested on Linux). (Sorry for the previous accidental commit. :-)
*** Bug 95424 has been marked as a duplicate of this bug. ***
It wasn't rpotts. I'm not sure who else to try backing out.
pollmann, Do you have any idea what could have triggered this?
Session History does save and restore the LayoutHistoryState properly for all pages. I think the problem is down in layout.
Giving it to pollmann, while I invetigate exactly when this stopped working.
Assignee: radha → pollmann
Looks like it was bryner@netscape.com's nsDocShell.cpp rev 1.340 checkin: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/docshell/base&command=DIFF_FRAMESET&file=nsDocShell.cpp&rev1=1.340&rev2=1.341&root=/cvsroot Note that this checkin also causes blocker 95243. I attatched a patch to 95243 that backs out his changes.
I got clearance for the backout. Taking this bug.
Assignee: pollmann → kin
Checked in backout patch: mozilla/docshell/base/nsDocShell.cpp revision 1.343
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I still see this bug with a fresh CVS Win32 build (made about 17:00 PDT). Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This was fixed for me when I pulled kin's checkin yesterday.
I'm going to mark this fixed again to get it off the smoketest blocker radar since it really seems fixed and only one person has reported otherwise. If you still see specific problems, they should probably be filed as separate bugs, unless it's still that all layout state restoration is completely broken.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
At least the scroll position is still not remembered. Even if form states are remembered, the bug should be downgraded but not fixed. I cannot check that with today build (crashes) but yesterday late night (PDT) CVS build still had this problem (WindowsME).
It's strange that Jacek is seeing a problem. I tested 2 different builds (Linux and Win32) that exhibited both the scroll position and form element value problems, and in each of them, things started working again when I backed out bryner's patch.
It's kind of inconsistent. Scroll positions are remembered with some pages (for example http://linuxtoday.com/ or http://www.bluesnews.com/) but not for others (like http://www.stomped.com/ or the abovedescribed Bugzilla bug list, say bugs reported today likned from http://bugzilla.mozilla.org/). All four pages are long.
Weird. The comment was sent in midtyping. Sorry.
Jacek, sorry, you ran into a regression I caused with my fix for bug 22526 - pressing Enter in textarea's submits the form. Any build before 2001-08-16 00:43 or after 2001-08-16 13:49 should not have this problem.
Thank you. I was just starting to file a bug on that. You saved me some work. See also my comments on bug 92342.
VERIFIED Fixed
Status: RESOLVED → VERIFIED
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in before you can comment on or make changes to this bug.