953 - URL: news: protocol causes ASSERT

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect, P5)

Description

[Bryce Harrington]

Ran into a PR_ASSERT when I clicked on a news link.

Cause:
------

/* get a handle to a protocol implemenation
 */
NET_ProtoImpl *
net_get_protocol_impl(int for_url_type)
{
	int count=0;

	/* if we ever get around to doing dynamic protocol loading
	 * this would be a good place to plug it in.
	 * just load a DLL with the implementation and
	 * return the handle.
	 * The integer URL_TYPE would need to be replaced with
	 * strings or some other identifier so that it can all be
	 * handled dynamically
	 */

	for(; count < net_number_of_proto_impls; count++)
	{
		if(net_proto_impls[count].url_type == for_url_type)
			return net_proto_impls[count].impl;
	}

/* >> */ PR_ASSERT(0);  /* should always find one */
	return NULL;
}


I hit the above assert line.

I'm guessing this is hit because the news client isn't available, right?
It'd be nice if instead of asserting, a dialog to this effect popped up.


System:
-------
I'm running WinNT4.0 SR3, on a 166MHz Dell Pentium with 64MB RAM and
200MB swap.  In addition to WinNT processes and mozilla, I am running
cdplayer.exe, MSACCESS, TASKMGR, MSDEV, CRT, PowerPoint, Netscape 4.06,
and a notepad-like editor.

Comment 1

[leger]

Setting all current Open/Normal to M4.

Comment 2

[Paul MacQuiddy]

setting paulmac as QA contact for all gagan's bugs (sorry for the spam)

Comment 3

[Gagan]

Marking till Necko lands...

Comment 4

[Chris McAfee]

cc-ing sspitzer, Mr. News.

Comment 5

[Gagan]

Per DP's suggestion marking these till M8. Though Necko lands with M7, we will
be able to verify it for M8.

Comment 6

[James Everingham]

I'm moving this to target M9, Necko will be enabled somewhere during late M8 or
early M9.  We will need to get on this and it cannot be postponed past the M9
milestone.

Comment 7

[leger]

Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)

Comment 8

[Gagan]

Fixed with Necko.

Comment 9

[Paul MacQuiddy]

seems to just ignore it now - is this acceptable? I'm not sure what the
immediate plan is here. Anyone?

Comment 10

[(not reading, please use [e-mail] instead)]

eventually, this should do what 4.x did:

news://host/article should bring up the article in a browser window.
news://host/group should open up messenger, and autosubscribe you to group at
the news server host.

none of this works yet, though.

these should be two seperate bugs, (one for host/group, one for host/article)
and logged against me.

I'll log these now.

Comment 11

[(not reading, please use [e-mail] instead)]

bugs #11075 and #11076 logged against me.

Comment 12

[Paul MacQuiddy]

thanks, seth. guess that covers it, marking this one verified i suppose

Comment 13

[leger]

Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.

Comment 14

[benc]

news: URLs as implemented are do not follow RFC 1738 compliant, as described in
bug 133792.

Comment 15

[benc]

-> mailnews.