959820 - Rename drawSystemFocusRing to drawFocusIfNeeded

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Rik Cabanier]

The HTML A11y group decided to rename drawSystemFocusRing to drawFocusIfNeeded since it is less confusing.

Comment 1

[Rik Cabanier]

Attachment: Renamed idl + impl + test files

Try run: https://tbpl.mozilla.org/?tree=Try&rev=0d606c9e0eeb

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8360152 [details] [diff] [review]
Renamed idl + impl + test files

Review of attachment 8360152 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

By the way, should we remove drawCustomFocusRing? It seems the name and/or behavior are likely to change and it won't be standardized for some time.

Comment 4

[Rik Cabanier]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> By the way, should we remove drawCustomFocusRing? It seems the name and/or
> behavior are likely to change and it won't be standardized for some time.

I was planning on leaving it behind the runtime flag for now. 
Maybe it's better to remove it since it is not going to be adopted? If you think so, I will create a bug to remove it.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Maybe it should have its own runtime flag. We probably should enable drawFocusIfNeeded before drawCustomFocusRing.

Comment 6

[Rik Cabanier]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5)
> Maybe it should have its own runtime flag. We probably should enable
> drawFocusIfNeeded before drawCustomFocusRing.

OK. I will introduce a new flag for customfocusring.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81e542a2ab70

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/81e542a2ab70

Comment 9

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/Firefox/Releases/29#Interfaces.2FAPIs.2FDOM
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D.drawFocusIfNeeded