96134 - message Save As ignores selected file type

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[K Chayka]

win32 build 2001081504, but has been happening forever and is making me crazy.

The default Save As file name for messages is "mail" with no extension.
The default Save As file type for messages is Mail File (.eml).
When the Save As file type is changed to something else, the message is still
saved in an .eml format unless an extension is manually added to the file name.

I get a lot of mail messages with a Content-Transfer-Encoding of
quoted-printable. I change the default file name and change the Save As file
type to Text (.txt), but if I don't manually add a .txt extension to the file
name it still gets saved as a .eml format complete with the "=" for line breaks.
When these files are saved with a .txt extension, that junk gets stripped out
like it should, even when the Save As file type is left at .eml.

Please, please, honor the selected Save As file type when no extension is
manually added to the Save As file name. Better yet, add the extension according
to the selected type if none is included in the Save As file name.

As it stands, the Save As file type selection is pretty useless.

Comment 1

[Keyser Sose]

Marking these all WORKSFORME sorry about lack of response but were very
overloaded here. Only reopen the bug if you can reproduce with the following steps:

1) Download the latest nightly (or 0.9.6 which should be out RSN)
2) Create a new profile
3) test the bug again

If it still occurs go ahead and reopen the bug. Again sorry about no response
were quite overloaded here and understaffed.

Comment 2

[K Chayka]

win32 build 2001110903, win98se

The only real difference between now and then is that message.eml is the default
file name.  If the file type in the "Save as type" drop-down is changed to "Text
Files", the file extension remains .eml and the file is saved in Mail File
format, not as a Text file.

If the file extension is manually changed to .txt, the file is saved as a Text
file regardless of which Save as type was selected.

The Save as type is completely ignored.  Only the file extension counts.

Comment 3

[R.K.Aa.]

*** Bug 120499 has been marked as a duplicate of this bug. ***

Comment 4

[R.K.Aa.]

confirming, based on dup

Comment 5

[Guenther ALBRECHT]

Mac PPC 2002020405 - This is a MAC bug also.
but has been a problem in Netscape Comm. up to 4.77, where you had to create a
mime type in prefs to be able to save source text in SimpleText format
(Type/Creator) for the file server - on double-click the user gets the text.
Mac mozilla / Netscape 6.2 have Save As... WITHOUT type selector. "message.eml"
is saved, mostly containing no data in mozilla. 
Clicking the "message.eml" document, opens mozilla / Netscape 6.2, who is unable
to display it.
the mime type def does work no longer....

[e-mail]

Comment 6

[Boris 'pi' Piwinger]

This is also happening in Linux (setting OS=ALL, also by previous comment).

For me it is the other way round. I want to save a mail in mbox format (i.e.,
save as mail files). I change the name to mbox.txt and the mail is no longer
saved in the format shown, but as a text file.

pi

Comment 7

[grylchan]

*** Bug 116117 has been marked as a duplicate of this bug. ***

Comment 8

[grylchan]

this also applies to exporting an addressbook as the file type is not
exported. You have to mannually type extension in order
to save it as correct file type.

Comment 9

[grylchan]

Nominating for rtm..

I think enterprise users will get frustrated when trying
to save a mail mesg as something other than eml type(html,txt) and
see there is no file extension unless they manually type it
in the filename area before they save.

Also since people want to may export their addressbook as
ldif file, it won't be exported unless you manually type in
the .ldiff extension.

Comment 10

[Michael Buckland]

Discussed in mail news bug meeting. Decided to minus this bug.

Comment 11

[grylchan]

*** Bug 157176 has been marked as a duplicate of this bug. ***

Comment 12

[grylchan]

clearing keyword nbeta1- and renominating by adding nsbeta1
affects all platforms and prevents you from opening
your locally saved mail as it doesn't know what application
to open the mail mesg in (html, eml, etc..)

Comment 13

[Boris 'pi' Piwinger]

I don't understand why this has a target milestone. Anyways, we missed it. I
don't know the code, but I imagine it is not too complicated to always save in
the format explicitely given in the dialog. Maybe we can have it for 1.2b.

pi

Comment 14

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 15

[(not reading, please use [e-mail] instead)]

accepting.

I have a patch in hand that makes things better, but there are some open issues.

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: fix, plus some code cleanup.

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: patch

I've addressed the "open" issue by making 3 seperate calls to AppendFilters()
[like we do in contentAreaUtils.js], so that GetFilterIndex() will return the
expected index.

Comment 18

[(not reading, please use [e-mail] instead)]

Attachment: updated patch, more code cleanup

Comment 19

[(not reading, please use [e-mail] instead)]

Attachment: more code cleanup

Comment 20

[(not reading, please use [e-mail] instead)]

Attachment: final diff

Comment 21

[(not reading, please use [e-mail] instead)]

fixed.  this has r/sr=bienvenu

but there are still issues.

just like with browser's right-click-save-page-as, the selected Save As file
type take precendence over the extension.

which means on windows, the file name might be message.eml, but the file will be
html (or plain text)

Comment 22

[(not reading, please use [e-mail] instead)]

when nbaca gets to this, we'll decide what follow up bugs to spin off.

Comment 23

[esther]

to summarize,

the save as type picker takes precedence over the file name. (foo.txt, foo.html,
foo.eml)

but if you pick the "all" type, then we use the file name extension to determine
the format.

if you pick "all" and don't specify an extension, it will save as eml.

note, the default name is message.eml, but on the file save as picker on win2k,
you only see "message".  (winxp, linux, and Mac OS X don't do this, they show
message.eml)

here's some open issues:

if name the file foo.eml, but choose html as as the file save type, the file
will be saved as html, but since the name is .eml, a windows operating system
will think it's a mail file, and if you open in mozilla, we think it's a mail
file, so it will appear blank.  we're probably not going to fix it.

one possible improvement is to make the default save as type "all", so that if
the user changes the file name (but not the save as file type), we'll do the
right thing.

reopening for that fix.

Comment 24

[(not reading, please use [e-mail] instead)]

Attachment: patch, per esther's comments.

Comment 25

[(not reading, please use [e-mail] instead)]

fixed esther's issue.

r/sr=bienvenu.  marking fixed.

Comment 26

[esther]

Using trunk build 20030325 on winxp, mac osx and linux this is fixed.  Default
save as format is "All files".  If a user changes the file name changing the
.ext only (not the format type), the  .eml .html and .txt displays according to
their extension.  Verified 

Notes for future testing if regression happens this is how it works with this fix:

Format File Type "All Files" not changed, filename extension changed:
.html = displayed as html
.eml = displayed as eml
.txt = displayed as text (header and body of message)

Format File Type changed but default filename extension .eml not changed:
All files = displayed as eml
html = displayed as html source
text= displayed as text (body of message only)
eml = displayed as eml

Format File Type "All Files" not changed, filename removes .eml and has no extension
All Files = displayed as eml
html = displayed as html
text= displayed as text (header and body of message)
eml= displayed as message source