96595 - The method nsHTMLInputElement->Click() don't work for Image-Buttons

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Volko Schwampe]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:0.9.2)
Gecko/20010726 Netscape6/6.1
BuildID:    20010802  (mozilla 0.9.3)

In method nsHTMLInputElement->Click() Image-Buttons are not considered:

<snip> (from \mozilla\content\html\content\src\nsHTMLInputElement.cpp)
NS_IMETHODIMP
nsHTMLInputElement::Click()
{
[...]
 // see what type of input we are.  Only click button, checkbox, radio,
 // reset, submit, & image
 PRInt32 type;
 GetType(&type);
 if (NS_FORM_INPUT_BUTTON == type ||
     NS_FORM_INPUT_CHECKBOX == type ||
     NS_FORM_INPUT_RADIO == type ||
     NS_FORM_INPUT_RESET == type ||
     NS_FORM_INPUT_SUBMIT == type) {
 [...]
 }
}
</snip>

I think
    || NS_FORM_INPUT_IMAGE == type
is missing! 

Reproducible: Always
Steps to Reproduce:
1. call method nsHTMLInputElement->Click() for an Image-Button
2.
3.

Actual Results:  nothing

Expected Results:  The Image-Button should be clicked

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.

Comment 2

[Keyser Sose]

Marking NEW. It needs a patch and review

Comment 3

[basic]

Attachment: untested patch

Comment 4

[Joe]

PLEASE also add the FILE type of user input! IE allows the click() method to be 
assigned to the FILE input object. It has G R E A T uses for the File input 
type.

Comment 5

[Fabian Guisset]

Nothing to do with layout, sending to DOM HTML. Per the W3C DOM Level 1 HTML we
do the Right Ting (TM), but I don't understand the reason why images are
excluded. Also CC'ing mstoltz for possible security implications of allowing
click() on input type="file" elements.

Comment 6

[Mitchell Stoltz (not reading bugmail)]

What will calling Click() on a file input element do? Is it the same as calling
Submit()? Or does it bring up the filepicker? If the former, then that's OK,
because a script can already call Submit(). It it's the latter, that's a little
weird. It might be a good spoof or DoS.

Comment 7

[Johnny Stenback (:jst)]

Would someone care to write a testcase for this bug? Both image and file inputs
please.

Comment 8

[Sivakiran Tummala]

working on testcase

Comment 9

[Sivakiran Tummala]

Attachment: zip file with testcase and image

Comment 10

[Sivakiran Tummala]

Attachment: new testcase and image

Comment 11

[Sivakiran Tummala]

Attachment: testcase for file input

Comment 12

[Sivakiran Tummala]

for the testcase attach id 59906, ie shows the alert and then the dialog for 
selecting a file when clicked on browse. ns6 does the other way. 

Comment 13

[Rob Landon]

This is a problem for us too.  We use an IMG element next to an A element.  If 
you click on the A element, it forwards to the IMG click().  Well, it used to...

We're going to look at work-arounds, but I thought I add another comment.  
People use IMG elements a TON, so...

Comment 14

[Johnny Stenback (:jst)]

Mass-reassigning bugs.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 52110 [details] [diff] [review]
untested patch

This patch makes sense.  The file input discussion does not, to me.  So I think
we should just go with this...

Comment 16

[Johnny Stenback (:jst)]

Comment on attachment 52110 [details] [diff] [review]
untested patch

Like, yeah, just what the comment above this code says.

sr=jst

Comment 17

[Boris Zbarsky [:bzbarsky]]

Checked in.  Marking fixed.  Please file separate bugs on the <input
type="file"> thing if someone actually wants that...