96817 - Menu item spacing is larger for Bookmarks Menu

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[doctor__j]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.3+) Gecko/20010823
BuildID:    2001082306

Summary says it all.
See screenshot for comparison with other menu.

Comment 1

[doctor__j]

Attachment: Screenshot fot comparison

Comment 2

[Scott Tran (Wildcard)]

*** Bug 96578 has been marked as a duplicate of this bug. ***

Comment 3

[Grey Hodge (jX)]

*** Bug 97885 has been marked as a duplicate of this bug. ***

Comment 4

[Joni K]

I'm seeing this on Linux and Windows 2000 as well. This bug was introduced
sometime between 0.9.3 and 0.9.4.

Comment 5

[Gervase Markham [:gerv]]

Not present (or not really noticeable) in the Classic skin. 

I suspect this is because the graphics are a touch too big for the default text
size.

Gerv

Comment 6

[Joe Hewitt (gone)]

This was probably caused by blake's checking for bookmark folder drag and drop.
 He added some transparent borders which turn black to indicate a dnd insertion
point. Should be trivial to fix.

Comment 7

[Grey Hodge (jX)]

It isn't on Classic at all from what I can tell. I reported a dupe of this.
Seemed to show up maybe a month/5 weeks ago, at a guess.

If it's the invis borders just taking up too much room, it should be easy, yeah.
The trick is knowing where to look for them in the code. :)

Comment 8

[Eugene Savitsky]

You can see the date around it did happened in general or seamonkey newsgroup. I
wrote there arond it began to happen.

It should be a message from Eugene Savitsky ([e-mail]).

Comment 9

[Joe Hewitt (gone)]

Mass reassigning my theme bugs to Shuehan.

Comment 10

[shliang]

Attachment: patch

Comment 11

[Joe Hewitt (gone)]

Comment on attachment 51791 [details] [diff] [review]
patch

sr=hewitt

Comment 12

[andreww]

Comment on attachment 51791 [details] [diff] [review]
patch

r=andreww

Comment 13

[shliang]

Attachment: doing this over

Comment 14

[Eugene Savitsky]

Any hope for 0.9.6?

Comment 15

[Blake Ross]

Yes, this is because of what hewitt said. Why are we 'fixing' this? It's the
same way in IE, and this is how it really should be for now...

Comment 16

[Grey Hodge (jX)]

The fix we're looking for is just to make them a bit smaller, not to get rid of
them. Since Classic doesn't have this problem, why should it be present in Modern?

Comment 17

[Joni K]

I agree with Grey. Besides, what's the same way in IE? I just checked and IE
doesn't have too much space between bookmark(favorite) menu items, unlike
Mozilla with the Modern theme.

Comment 18

[shliang]

checked in

Comment 19

[:deanis74]

Verified using 2001110203 on Win2K.  Also confirmed that the lines still show 
up when dragging a bookmark around in the Bookmarks menu on the Personal 
Toolbar.

Comment 20

[Grey Hodge (jX)]

Beautiful. We all thank you and your sons for seven generations. ;)

Comment 21

[Joni K]

There's still a small issue with the width of bookmarks and folders on the
personal toolbar. See the screenshot for comparison between Modern and Classic. 
(You can also see the difference, for example, between NS 6.1 and 6.2 using the
Modern theme.)

I don't know if this should be a separate bug, or if it's intentional perhaps...

Comment 22

[Joni K]

Attachment: screenshot: item width on personal toolbar