97486 - Not clearing out SMTP prefs after deleting an SMTP server

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Scott MacGregor]

This causes us to use this old information if you later add another SMTP server.
It can sometimes lead to a situation where you are unable to send to this new
sever because of the old settings which are sharing the same prefs name space.

The fix is easy. When the account manager tells the smtp service to delete the
smtp server, we need to iterate over all the prefs for that smtp server and
remove them. 

Fix coming. cc'ing Bhuvan because I may have filed this bug on him already.

Comment 1

[Scott MacGregor]

Attachment: the fix

Comment 2

[Scott MacGregor]

Here's a scenario where you can easily see the problem:
1) Create a new account for say dredd
2) Now create a new webmail or aol account
3) Remove that netcenter / aol account through the account manager
4) In the account manager, click on Outoing servers then on the Advanced button.
Delete the netcenter smtp server. 
5) Now quit the app

If you examine your prefs.js file you should still see mail.smtpserver prefs for
the netcenter server. In particular you should see a redirector pref in that list. 

Now restart the app.
6) Go back to outgoing server / Advanced. 
7) Create a new SMTP server (not webmail. use dredd or nsmail-1)
8) Try sending a message through that SMTP server. You should get a "send
failed" alert because we incorrectly read the stale redirector pref from the
previous server and think it's an aol / netcenter smtp server. 
9) If you quit the app and examine your prefs again, you should see your new
smtp server prefs under "mail.smtpserver......". You should see the stale
.redirector pref still in there. Ooops!!!

This patch fixes that. 

Comment 3

[racham]

r=bhuvan.

Comment 4

[(not reading, please use [e-mail] instead)]

sr=sspitzer

we should consider flushing the prefs file to disk in this case (and the account
manager case).

Comment 5

[Asa Dotzler [:asa]]

a=asa on behalf of drivers.

Comment 6

[Scott MacGregor]

fixed.

Comment 7

[Ninoschka Baca]

Trunk build 2001-11-09: WinMe, Linux RH 7.1, Mac 9.1
Verified Fixed.