97487 - break apart messenger.css and EditorToolbars.css to improve reply / compose performace

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[(not reading, please use [e-mail] instead)]

investigate files getting sucked into html mail compose

I've got the list from doing "mozilla -compose", I'll attach it.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: list of jar entries we use for html mail compose

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: css files that get sucked in

Comment 3

[(not reading, please use [e-mail] instead)]

weird, we are loading 

XXX opening mJAREntry = content/editor/EditorOverride.css
XXX opening mJAREntry = content/editor/EditorContent.css

every time we bring up the html mail compose window

(the rest of the necessary gif / xul / dtd / css / etc are cached)

investigating..

Comment 4

[(not reading, please use [e-mail] instead)]

also weird, at times we seem to open up entries more than once and some times 
we aren't.

XXX opening mJAREntry = skin/modern/editor/btn2/italic-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/italic-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/underline-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/underline-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/bold-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/underline-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/bold-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/inc-font-size-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/inc-font-size-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/dec-font-size-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/inc-font-size-hov.gif
XXX opening mJAREntry = skin/modern/editor/btn2/inc-font-size-hov.gif

Comment 5

[(not reading, please use [e-mail] instead)]

found a small optimization (patch on the way).

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: optimization, don't update title when doing mail compose, we do this ourselves in the mailnews compose js

Comment 7

[Blake Ross]

It seems wrong that messenger.css imports sidebar.css.  This forces us to load
sidebar.css in msg compose, even though we don't have a sidebar.

Comment 8

[Simon Fraser [no longer active]]

r/sr=sfraser on attachment 47564 [details] [diff] [review]

Comment 9

[(not reading, please use [e-mail] instead)]

I'm going to go lay the smack down on messenger.css, and split it up

Comment 10

[(not reading, please use [e-mail] instead)]

in addition to cleaning up messenger.css, EditorToolbar.css can be broken up.

mailnews compose only cares about the rules for the formatting toolbar.

that .css file contains rules for the composition toolbar (all the buttons you 
see in editor, new, open, save, browse, print, image, hline, table, link and 
anchor)
 
http://lxr.mozilla.org/mozilla/source/themes/modern/editor/EditorToolbars.css

the biggest wins so far are going to be cleaning up those EditorToolbars.css 
and messenger.css files.  

simply removing messenger.css [which is only used for icons in the Options | 
File Sent Message" picker], had a measurable impact (using the msgcompose nspr 
log module)

I tried a hack to see if caching EditorOverride.css EditorContent.css helped, 
and it didn't.  (but I'll log a bug on doing it, as it might help editor more 
than it does mailnews compose)

after I clean up the .css, I'll investigate a known big winner:  focus.  if we 
can avoid the focus switch that happens from editor body to address area, we 
would win.

Comment 11

[Scott MacGregor]

r/sr=mscott

Comment 12

[Blake Ross]

As far as I know (or as far as I can tell anyways), we no longer switch focus
from the editor body to the address pane upon loading.  See
http://lxr.mozilla.org/seamonkey/source/editor/base/nsEditorShell.cpp#647.

(I can't believe we handle stuff like that in *nsEditorShell*)

Comment 13

[(not reading, please use [e-mail] instead)]

blake, I'm not so sure about that.  at least, when I set breakpoints in ::Focus
and ::Blur in nsHTMLInputElement and nsTextEditorFocusListener I think I was
seeing focus going in and out of the editor.

after I investigate a blocker, I'll break apart those two .css files (which will
be a win), I'll resume debugging and confirm it.

Comment 14

[Scott MacGregor]

This won't be a .9.4 stopper so we're going to set the milestone to .9.5. But
keep working on it. 

Comment 15

[Blake Ross]

Well, note that the methods you mention will be called when the addresspane
textbox is focused.

Comment 16

[Blake Ross]

(oh, well ::Blur shouldn't be, of course)

Comment 17

[Joe Hewitt (gone)]

*** Bug 79808 has been marked as a duplicate of this bug. ***

Comment 18

[Joe Hewitt (gone)]

Attachment: patch to /mailnews

Comment 19

[Joe Hewitt (gone)]

Attachment: patch to /themes/modern

Comment 20

[Joe Hewitt (gone)]

Attachment: patch to /themes/classic

Comment 21

[(not reading, please use [e-mail] instead)]

ok, I've split apart EditorToolbars.css into three files:

editorPrimaryToolbar.css
editorModeToolbar.css
editorFormatToolbar.css

the affected dialogs are:

html editor
plain text editor
aim chat
aim conversation
html mail compose
plain text mail compose

here comes the patch for mozilla and ns.

Comment 22

[(not reading, please use [e-mail] instead)]

Attachment: commercial diffs

Comment 23

[(not reading, please use [e-mail] instead)]

Attachment: mozilla changes

Comment 24

[(not reading, please use [e-mail] instead)]

sr=sspitzer on hewitt's changes for mail.

thanks for doing this work.  in addition to compose perf improvements, it 
should help the other mailnews windows.

Comment 25

[Scott MacGregor]

r=mscott

Comment 26

[(not reading, please use [e-mail] instead)]

moving back to 0.9.4, we want this one for perf.

Comment 27

[Charles Manske]

r=cmanske on all editor changes.

Comment 28

[Asa Dotzler [:asa]]

a=asa on behalf of drivers.

Comment 29

[(not reading, please use [e-mail] instead)]

the editor stuff has landed.

Comment 30

[(not reading, please use [e-mail] instead)]

fixed.

messenger.css and EditorToolbars.css have been broken apart.

thanks to hewitt for doing the lion's share of the work.

I'll spin up a new bug about the focus / blur thing that's next.

Comment 31

[(not reading, please use [e-mail] instead)]

Attachment: classic skin, -compose, css files

Comment 32

[(not reading, please use [e-mail] instead)]

Attachment: classic skin, -mail, css files (sidebar had bookmarks)

Comment 33

[(not reading, please use [e-mail] instead)]

Attachment: classic skin, -addr, css files

Comment 34

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Comparison between 8-31 and 9-04 builds

Comment 35

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED, but only from a code level (using LXR).