97491 - nsCJVMManagerFactory.cpp contains unused obsolete code

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

nsCJVMManagerFactory.cpp contains a lot of unused (in the #else of an #if 1),
obsolete, code.  This should be removed to make it easier for people to
understand what the file does, and to reduce the amount of code people have to
download.  (It took me a minute or two to notice that 90% of the file was unused.)

I'll attach a patch that does this.

Ed Burns, could you review?

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[edburns]

ra=edburns IF you put in a comment in the .cpp file saying that in CVS version 
1.17 of this file, there was a lot of ifdef'd out code.  

Comment 3

[Chris Waterson]

Comment on attachment 47526 [details] [diff] [review]
patch

sr=waterson

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I just noticed that nsCJVMManagerFactory.h can be cvs removed, since it's not
needed at all anymore.  I'll attach a new patch.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: revised patch

Comment 6

[Chris Waterson]

Comment on attachment 48923 [details] [diff] [review]
revised patch

sr=waterson

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in 2001-09-10 17:42 PDT.

Comment 8

[Patty Mac]

Verified the patch.