97512 - Navigation: Multi "advance to next unread" dialogs on multi space bar hits

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[laurel]

Using aug29 commercial trunk build
Found when trying to reproduce bug 97466

Pressing the spacebar multiple times when reading the last unread message in a
folder (when there are unread in other folders or accounts) causes multiple
"advance to next unread message...?" dialogs to be displayed.  We shouldn't
display more than one.

4.x behavior: only one dialog will display, the second spacebar hit will be
translated as confirm/OK (since OK is the default).  

I'm not sure if we want to adopt the second spacebar==confirm part, but in any
case we shouldn't display multiple dialogs.

In the case where I'm prompted to go to another account requiring
authentication, I'm also seeing multiple login prompts (each login prompt
appears behind respective copy of "advance to next unread" dialog). Another
issue:  I'm not even sure we should be showing a login prompt until user has
confirmed OK to cross the account.

Basic scenario steps (navigation to same account):
1.   Open a folder with no unread messages.  There are unread messages in
another folder.
2.   Select a message, use the spacebar to read through the message.  
3.   At the end of the message, hit the spacebar several times (as you might if
you were speeding through the message).

Result:  several copies of the "advance to next unread message in <foldername>"
appear, each having to be dealt with.

Expected: no multiple dialogs.  (4.x used 2nd spacebar as confirm/ok)

Comment 1

[Chris Dolan]

While we're on the subject...

I have never been comfortable with space hopping to new folders.  I tend to hit
space too many times often (I'm used to the behavior of trn where extra spaces
are ignored) and I'm usually annoyed when I mistakenly hop to the next folder. 
I would prefer one of the following behaviors:
1) space at the end of the folder is ignored
2) space on "advance to next unread" is ignored (I usually hit esc to cancel)

Maybe this is too trivial, but I'd love to see a pref that turns off the folder
hopping feature entirely.

Comment 2

[Greg K.]

*** Bug 97466 has been marked as a duplicate of this bug. ***

Comment 3

[laurel]

problem still exists with dec14 commercial trunk build

Comment 4

[Alan Monroe]

The advance to next unread dialog may be broken altogether in 1.2 beta. Just now
when I was prompted to go to the next unread in another folder, I clicked on
next and nothing happened. I repeatedly clicked on the Next button on the
toolbar, and got prompted again as expected, but hitting OK on the dialog had
absolutely no effect. Anyone else seen this behavior?

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021016

Comment 5

[Matthias Bockelkamp]

Attachment: Patch

This is my first patch. Please tell me if I did something wrong.

Comment 6

[Matthias Bockelkamp]

Attachment: Patch with pref for enabling/disabling the dialog

Comment 7

[[e-mail]]

Comment on attachment 111926 [details] [diff] [review]
Patch with pref for enabling/disabling the dialog

There's already a suitable pref, mailnews.nav_crosses_folders

Comment 8

[Matthias Bockelkamp]

In general this now WFM because the dialog diappears when pressing the space bar
again. I'll change the patch addressing neil's comments for using
"mailnews.nav_crosses_folders" in order to detect if this dialog should appear
at all.

Comment 9

[Matthias Bockelkamp]

Attachment: See comment #8

Comment 10

[Matthias Bockelkamp]

Attachment: See comment #8

Comment 11

[Matthias Bockelkamp]

Comment on attachment 125656 [details] [diff] [review]
See  comment #8

One click too much...

Comment 12

[[e-mail]]

Comment on attachment 125657 [details] [diff] [review]
See  comment #8

Maybe I misunderstood you, or maybe you misunderstood me. The existing pref can
already be used to either a) stop next unread from crossing to the next unread
folder b) [default] prompt to cross to the next unread folder c) automatically
cross to the next unread folder.

Comment 13

[Matthias Bockelkamp]

Oh. I didn't check that. Just thought you wanted me not to introduce a new pref.
I think this bug can be closed then.

Comment 14

[Matthias Bockelkamp]

marking resolved wfm