98321 - HAVE_DEMANGLE not being used in code

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Matthew Cline]

When attempting to make the debug build on Linux, it fails because it
can't find the symbol cplus_demangle.  As far as I can tell, this is
because the use of cplus_demangle() isn't being bracketed by checks for
HAVE_DEMANGLE; in fact, acording to LXR, HAVE_DEMNAGLE doesn't appear
anywhere except for configure.in and configure

cplus_demangle() only appears to be used in /xpcom/base and /tools/leaky,
so I'm filing this under component XPCOM.

Comment 1

[Edward Kandrot]

MOZ_DEMANGLE_SYMBOLS appears to be the define that switches cplus_demangle 
on/off.  This appears to be bracketed by HAVE_DEMANGLE in the configure.in 
file, so it should not be using cplus_demangle unless HAVE_DEMANGLE is defined, 
which is what you are requesting.  I do not know why it is not working for 
you.  I am going to reassign it to the default build owner to see if he knows 
of any problem with this define.

Comment 2

[hacker formerly known as [e-mail]]

I don't see how that problem would occur.  HAVE_DEMANGLE is only set if
configure detects that you have -liberty and that it contains cplus_demangle. 
Do you see that problem with the recent milestone release (0.9.6) or a cvs build?

Comment 3

[Matthew Cline]

Looks like it's fixed; when I filed the bug, the debug build wouldn't compile
without libiberty.  Marking FIXED.

Comment 4

[hacker formerly known as [e-mail]]

Hate to be the bearer of bad news, but that's soon to be the situation again. 
See bug 112470 .

Comment 5

[Tracy Walker [:tracy]]

verified