98455 - OS X: menus should crop long titles

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[sairuh (rarely reading bugmail)]

found using 2001.09.04.08-comm bits on os x [10.0.4].

1. go to a page with a really long title.
2. bookmark that page.
3. dropdown the Bookmarks menu. also, dropdown the Go or Tasks menu.

observe: both the Bookmarks, Go and Tasks menus are very, very wide --the page
title isn't being cropped.

not a problem on mac os 9.1.

Comment 1

[John Morrison]

sairuh, is this really only OS/X? Were you using the same skin on both OSX
and OS9? The Mac classic skin provides no max-width for menu items, but 
the Modern skin does (42em for some definition of em). 

Comment 2

[Simon Fraser [no longer active]]

Mac OS X has much larger menu font sizes that 9, so this is really noticeable on 
X. Menu slowness is also confounded by the menu being translucent, which makes it 
really slow to draw screen-wide menus.

Comment 3

[sairuh (rarely reading bugmail)]

john, i see this using either modern or classic on os x. i don't see it with
either theme on os 9, where the title is cropped in the menus.

Comment 4

[Mike Pinkerton (not reading bugmail)]

this has nothing to do with themes. it's in the os-specific menu code.

Comment 5

[Mike Pinkerton (not reading bugmail)]

should be as easy as it was with the os9 menu code. 

Comment 6

[Mike Pinkerton (not reading bugmail)]

Attachment: truncate long menu titles

Comment 7

[Mike Pinkerton (not reading bugmail)]

i would be needing in your pleasure of a review, thank you.

Comment 8

[Steve Dagley]

Comment on attachment 51724 [details] [diff] [review]
truncate long menu titles

pleasing to I give you r=sdagley

Comment 9

[Simon Fraser [no longer active]]

Comment on attachment 51724 [details] [diff] [review]
truncate long menu titles

sr=sfraser

Comment 10

[Jaime Rodriguez, Jr.]

let it bake on the trunk for a couple of days, then let's see if we can take it.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 51724 [details] [diff] [review]
truncate long menu titles

a=asa (on behalf of drivers) for checkin to 0.9.5.

Comment 12

[Mike Pinkerton (not reading bugmail)]

landed on trunk, waiting for go-ahead on branch

Comment 13

[Jaime Rodriguez, Jr.]

pls check this into the branch - PDT+, after they have been verified on th trunk

Comment 14

[sairuh (rarely reading bugmail)]

tested using 2001.10.07.20-trunk comm bits on 10.0.4.

looks good! i checked the Bookmarks, Go and Tasks menus and they all cropped my
test file with the huge title.

Comment 15

[Mike Pinkerton (not reading bugmail)]

landed on MOZILLA_0_9_4_BRANCH.

Comment 16

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.10.10.04-0.9.4 comm [branch] bits on mac 10.1.