98805 - [turbo] Need confirmation dialog when "Disable QuickLaunch" systray icon menu choice is selected

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Bill Law]

Once we've made the leap to turning on QuickLaunch mode by default during
installation, we will need to make it easy for users to turn this off (so they
can get rid of that mysterious icon that then appears in their system tray). 
This is covered by bug 98770.

This bug says that in addition, that menu choice should first display a
confirmation dialog, worded along the lines of:

  You have chosen to turn off Mozilla/Netscape QuickLaunch.  This will increase   
  the time it takes to open this application.  Are you sure?  If you say "Yes", 
  then to turn QuickLaunch mode back on, you must go to Preferences|Advanced and 
  select the QuickLaunch checkbox.

Comment 1

[Blake Ross]

law, do you mind if I take this?  I have it working.  If you've already done the 
work, we can use your patch or merge as necessary.

Comment 2

[Blake Ross]

The patch for this is in bug 89532.

I didn't make this a confirmation because I don't recall us saying that in the 
meeting, although if that's what's wanted I can.  It sounds like a good idea 
since the item is right above Exit (can be easily hit), and not necessarily 
immediately understandable.

Comment 3

[Mike Young]

The current dialog is an alert dialog. It should be a confirmation so people can
have a choice if they accidentally hit the menu item. 

Comment 4

[Peter Trudelle]

Yes, we specifically agreed on a confirmation dialog that allowed the user to
cancel.

Comment 5

[Peter Trudelle]

nsbranch

Comment 6

[Jaime Rodriguez, Jr.]

Marking as nsbranch- per PDT.

Comment 7

[Blake Ross]

Attachment: patch

Comment 8

[Blake Ross]

I just made up some wording; need official wording from Jatin.

Comment 9

[Jatin Billimoria]

My suggested wording:
"Disabling Quick Launch will increase the time it takes to start [short name].
To enable it again, open the Edit menu and choose Preferences. Choose the
"Advanced" category and check "Enable Quick Launch." Are you sure you want to
disable Quick Launch?"

Comment 10

[Bill Law]

Blake,

The code looks good with the exception of one concern:  I think in the case
where there are no windows open when the user chooses "Disable Quick Launch,"
then the confirmation dialog will trigger the "Mozilla is still running in turbo
mode" warning if that dialog is "active."

You may need a member flag to tell OnLastWindowClosing to ignore this particular
window closing.  Note that previously, OnLastWindowClosing would ignore the
alert because we had already gone ahead an turned mServerMode off (so it just
returned NS_OK).

Comment 11

[Blake Ross]

Attachment: great catch!

I hate that this stuff is all built into nsNativeAppSupport.

Comment 12

[Blake Ross]

Attachment: updated

Comment 13

[Bill Law]

Comment on attachment 60738 [details] [diff] [review]
updated

r=law

Note that I've only reviewed the portion of this patch that relates to bug
98805 (basically, Blake's original patch, plus the mLastWindowIsConfirmation 
additions).

Comment 14

[Joe Hewitt (gone)]

Comment on attachment 60738 [details] [diff] [review]
updated

sr=hewitt

Comment 15

[Peter Trudelle]

Blake, do you still plan to land this in 0.9.8? 

Comment 16

[Blake Ross]

okay, fixed.