99118 - x remote client can't ever send commands

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Christopher Blizzard (:blizzard)]

If you try to use mozilla -remote with some window managers with the new server
code in place there's a good chance that it won't find a running mozilla.  My
new server code exposed this bug.

The problem is that the client walks only the list of windows found that are
direct decendants of the root window.  Because of the way that window managers
work you have to walk down the full tree to find the managed windows and only
find windows with WM_STATE on them to check to see if they have the
_MOZILLA_VERSION atom on them.

The only reason that the old code worked at all is that I used to listen to
remote requests on popup windows which aren't managed by the window manager. 
Fancy that.

Patch follows.

Comment 1

[Christopher Blizzard (:blizzard)]

Attachment: client patch

Comment 2

[Alec Flett]

easy enough. sr=alecf

Comment 3

[Brian Ryner (not reading)]

r=bryner

Comment 4

[Christopher Blizzard (:blizzard)]

Checked in.