99169 - ftp: display file sizes in a nicer format

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P4)

Description

[sairuh (rarely reading bugmail)]

go to above url and select one of the build dirs. notice that the file sizes are
all in bytes. it would be good to nicely them [ie, large files] to the closest
kilobyte, as in communicator 4.x.

Comment 1

[Bradley Baetz (:bbaetz)]

Yeah, I can do this for the html listing. Taking.

This may be a dupe; I know its been mentioned to me before.

Comment 2

[Bradley Baetz (:bbaetz)]

targetting. This will be ugly i18n-wise, and unless we have a function to do
this already I'll probably end up futuring this.

Comment 3

[Simon Fraser [no longer active]]

Don't the nsILocale interfaces give you locale-based decimal point information? I 
happen to think this is a pretty serious issue with our FTP listings, because it 
makes it very hard to easily guage large file sizes (quickly, how big is 72134567 
bytes?).

Comment 4

[Bradley Baetz (:bbaetz)]

Probably. The problem isn't the location of commas - thats easy to fix, and I'll
add that to my dirviewer rewrite over the weekend. (see bug 78148)

Note se's original comment - we want the sizes divided by 1024^n bytes (I guess,
some may push for 1000), and the appropriate prefix added. Since the html viewer
isn't localisable (theres a bug on that), thats not that hard.

However, doing so for the XUL viewer is problematic, since you want to store
numbers so that sorting works, but need strings to add commas. I'm going to
rewrite that to use <outliner> though at some point Soon, so it may be possible
(using a custom nsIOutlinerView rather than rdf. The rdf version will be first
though)

Comment 5

[Bradley Baetz (:bbaetz)]

Actually, I can't see how to get comma separated numbers. I can do it on linux
with printf("%'d", number);. but ' is an SuSv2 extention, so won't be widely
available.

smfr, do you know how to do this in mozilla? I can't see any numeric support -
the words numeric or number don't appear anywhere useful in intl/*

OTOH, since we're not localisable at the moment anyway, I could just implement
it for english only, I guess.

Comment 6

[Bradley Baetz (:bbaetz)]

Fixed. We now only display Kb, because its too confusing otherwise. See bug
38014 for that discussion

Comment 7

[Peter Lairo]

I created bug 108658 to add thousands separators. 

Even if this is difficult to fix, it is very important for readability. Most
people cannot visually scan a long string of numbers and quickly determine the
filesize to an accuracy within a factor of ten.

In the age of DSL, large fies are becomming very common.

Quick: What size is 137892 kb? Kommas would have told you the size at a "glance"!

Comment 8

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.11.08.0x-comm bits on all platforms.

however, i'm seeing diffs in display btwn http and ftp listings --filed bug
109137 for those.