99222 - If only one match during auto complete, don't show the popup

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Scott MacGregor]

This is to track one of our UI issues with the auto complete widget that came
out of our issues meeting today. 

Currently if I type in an exact match (or something that has only one match), we
always show the popup underneath your text showing the address with the default
domain AND the match. 

We really want the 4.x behavior in this scenario where there is no popup, we
just show the completion of the exact match.

i.e.

Scott MacG >> "Scott MacGregor <[e-mail]>"

Comment 1

[Scott MacGregor]

fix coming up. After talking to Joe, I've added an attribute to the auto
complete widget where you can specify the required # of matches before the popup
is shown.

Comment 2

[Scott MacGregor]

Attachment: the fix.

Comment 3

[Jean-Francois Ducarroz]

Comment on attachment 48964 [details] [diff] [review]
the fix.

looks good to me. R=ducarroz

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 48964 [details] [diff] [review]
the fix.

sr=sspitzer

Comment 5

[Scott MacGregor]

Hewitt, the module owner of auto complete has approved this change.

Comment 6

[Scott MacGregor]

this fix is now baking in the trunk. It'd be great if some of you could try this
out in tomorrows builds and make sure things look okay. If it looks good and
checks out then I'll move this into the nsBranch+ list. 

Comment 7

[Marek Z. Jeziorek]

nsbranch+ per pdt triage

Comment 8

[Scott MacGregor]

this usability change to the autocomplete widget was PDT plusse at Friday's PDT
meeting. Making it reflect that reality.

Comment 9

[Scott MacGregor]

fixed on the branch. Filed spin off bug 100152 to keep track of a minor issue
where the popup still stays up when you first have multiple matches then type
more text to have only an exact match.

Comment 10

[yulian chang]

Verified with 20010925 0.9.4 builds on NT, Linux,MacOS 9.2 and MacOS X.