99545 - can not use the alignment buttons if text styles (bold, italic, and underline) are set before typing

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[TucsonTester2]

Build: 2001091003

If you add in text styles before you begin typing in composer then click on an
alighnment button the text will not center nor will the html be added, but the
alignment button shows as if the text is aligned differently.

Reproducibility: Every time

Steps to Reproduce:
1. Open composer
2. Click on the Bold button on the toolbar
3. Click on the Center alignment button on the toolbar
4. Type in some text

Actual Resutls:
You will notice that the alignment will show it's centered in the toolbar, but
in the actual page itself it does not show the centered alignment.  If you take
a look at the HTML source you will see that there was no div tag added.  Also
the bold option is removed, I don't know if this is another bug or not but that
also happens.

Expected Results:
I would expect that the alignment and bold options would stick.  And that the
correct alignment would be displayed.

Comment 1

[michael wendell]

Confirmed on build 2001091303.

Comment 2

[kinmoz]

--> jfrancis

Comment 3

[TucsonTester1]

More information on this report. If you click the Alignment button BEFORE
clicking the text style button, it will work properly. If you choose any other
text style before clicking on the Alignment button, it will not work. The tags
are not placed in the html source.

Comment 4

[TucsonTester1]

This problem also seems to happen if you start with a different color. It
affects all font stylings and all alignments. I am using build 2001121003 and
win ME. 

Comment 5

[Kathleen :Brade]

Joe--is this a bug Daniel could help with?
Daniel--is this still a bug after your landing?

Comment 6

[Joe Francis]

pushing off 098 to 099

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0

Joe, Kin, can you review this patch please ?

Comment 8

[Syd Logan]

plussing

Comment 9

[kinmoz]

Comment on attachment 65980 [details] [diff] [review]
patch v1.0

Get and r=jfrancis and you got my sr=[e-mail].

  - Initialize divType with it's value when it's declared.

  - I don't think you need to vars tmp and theElement in the while loop.

Comment 10

[kinmoz]

My last statement above should have said "two vars".

Comment 11

[Joe Francis]

Comment on attachment 65980 [details] [diff] [review]
patch v1.0

I feel bad about vetoing this patch, but i think it's the right thing.	Other
recent bug fixes have gotten things to the point where things are almost
working already.  The only remaining problem in the current tip is that we need
a br node inside this div so that we get a proper caret.  Otherwise this is
already working.

I think the right thing to do here to check at postprocessing time
(AfterEditInner) if we are in an empty block, and if put in a br.  I beleive
the best place to put this code is either in AdjustSelection() or by overriding
CreateBogusNode() in the html rules and adding it there.

Comment 12

[Joe Francis]

Hey, I had this code in Adjustselection()  (I had just put it in last week!)  I
reordered some things so that it always happens now, instead of sometimes.  This
fixes this bug and 103677.  

Comment 13

[Joe Francis]

fixed on tip

Comment 14

[michael wendell]

Verified on Win XP using trunk build 02-20.