996307 - Enable sccache for b2g desktop linux builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

The B2G desktop Linux builds are very similar to non-B2G Linux builds, so it is pretty straightforward to enable sccache on them.

Comment 1

[Michael Shal [:mshal]]

Attachment: setup.sh

Setup script for tooltool

Comment 2

[Michael Shal [:mshal]]

Attachment: 0001-Bug-996307-enable-sccache-for-B2G-Desktop-Linux-buil.patch

Valgrind builds include mozconfig.cache, but we don't seem to use tooltool there. I've replaced the use of no_tooltool with no_sccache to distinguish between using tooltool for gcc, and using tooltool for sccache.

This also removes the old ics.manifest and releng.manifest that were removed in bug 909907 and bug 780915, respectively.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8406497 [details] [diff] [review]
0001-Bug-996307-enable-sccache-for-B2G-Desktop-Linux-buil.patch

Review of attachment 8406497 [details] [diff] [review]:
-----------------------------------------------------------------

302 glandium :)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8406497 [details] [diff] [review]
0001-Bug-996307-enable-sccache-for-B2G-Desktop-Linux-buil.patch

Review of attachment 8406497 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/config/tooltool-manifests/ics.manifest
@@ -9,5 @@
> -"size": 63159127, 
> -"digest": "fcf629c815b5cbed7858d7697815f355275dcc6b060ae5455b4b31fde0d78ebc176927564a5353ceacdb9f9c9bfc1357f1341bf6ba844c25153a89664e661510", 
> -"algorithm": "sha512", 
> -"filename": "gonk-toolchain-7.tar.bz2"
> -}

This cleanup should be done separately (if at all)

::: browser/config/mozconfigs/linux32/valgrind
@@ +1,2 @@
>  no_tooltool=1
> +no_sccache=1

the l10n-mozconfig files have no_tooltool too, we may want to add no_sccache there too.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8406497 [details] [diff] [review]
0001-Bug-996307-enable-sccache-for-B2G-Desktop-Linux-buil.patch

Review of attachment 8406497 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/config/mozconfigs/linux32/valgrind
@@ +1,2 @@
>  no_tooltool=1
> +no_sccache=1

Ah, please add it to b2g/config/mozconfigs/common too, and explicitly reset no_sccache in the files that include mozconfig.common but shouldn't have sccache (and be aware of bug 996621)

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8406494 [details]
setup.sh

setup.sh:
sha512: 48f405d8c2712838b9dd3be118951c8b41c63c891576f5287d2e05afa8fd051a08807511259581aa3170a3c4f7d4e77e6c0539b00b8f6845f01562127f6a27fa
size: 50

Comment 7

[Michael Shal [:mshal]]

Attachment: 0001-Bug-996307-enable-sccache-for-B2G-Desktop-Linux-buil.patch

Is this what you're thinking for overriding no_sccache in b2g?

try: https://tbpl.mozilla.org/?tree=Try&rev=d51e8c918d7b

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8407939 [details] [diff] [review]
0001-Bug-996307-enable-sccache-for-B2G-Desktop-Linux-buil.patch

Review of attachment 8407939 [details] [diff] [review]:
-----------------------------------------------------------------

yes

Comment 9

[Michael Shal [:mshal]]

inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ac2c9d8212

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5ac2c9d8212