996960 - Add new RTL languages to locales.nsi - Uyghur ug and Urdu ur

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Ehsan, would you mind reviewing this? Thanks!

Comment 2

[(no longer active)]

CCing Simon and Pike to keep them in the loop.  We have two places to update when adding a new RTL locale.

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/ae585238d9a8

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8407242 [details] [diff] [review]
patch rev1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): This file was missed when adding the Urdu and Uyghur RTL locales.
User impact if declined: Urdu locale will not have a right to left installer or stub installer
Testing completed (on m-c, etc.): tested locally
Risk to taking this patch (and alternatives if risky): Extremely minimal
String or IDL/UUID changes made by this patch: None

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae585238d9a8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/049d7e6df527
https://hg.mozilla.org/releases/mozilla-beta/rev/92cae49290ae

Comment 7

[Petruta Horea [:phorea], Desktop QA (back on May 31)]

There are no ug or ur builds for Firefox 31 beta 1-4. 

I've found Aurora 32.0a2 ur builds and the installer (and stub) properly displays from right to left.