99808 - javascript errors in nsSidebar.js

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P4)

Description

[Alexey Chernyak]

Build: 2001091303

While browsing and installing tabs from
http://developer.netscape.com/evangelism/sidebar/ I got the following JS errors:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]"  nsresult:
"0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
file:///C:/Internet/Mozilla/bin/components/nsSidebar.js :: anonymous :: line
122"  data: no]

Error: [Exception... "Component returned failure code: 0x80004003
(NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]"  nsresult: "0x80004003
(NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
file:///C:/Internet/Mozilla/bin/components/nsSidebar.js :: anonymous :: line
122"  data: no]
Source File: file:///C:/Internet/Mozilla/bin/components/nsSidebar.js
Line: 122

Above 2 errors were immediately following these errors:

Error: [Exception... "'JavaScript component does not have a method named:
"getInterfaces"' when calling method: [nsIClassInfo::getInterfaces]"  nsresult:
"0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame
:: http://developer.netscape.com/evangelism/sidebar/ :: addTab :: line 100" 
data: no]
Source File: http://developer.netscape.com/evangelism/sidebar/
Line: 100

Error: [Exception... "'JavaScript component does not have a method named:
"getHelperForLanguage"' when calling method:
[nsIClassInfo::getHelperForLanguage]"  nsresult: "0x80570030
(NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame ::
http://developer.netscape.com/evangelism/sidebar/ :: addTab :: line 100"  data: no]
Source File: http://developer.netscape.com/evangelism/sidebar/
Line: 100


These also were preceeded by JS strict warnings described in bug 78485, as well
as warnings in:
http://developer.netscape.com/evangelism/teds-sidebar.html
http://developer.netscape.com/evangelism/sidebar/

Comment 1

[John Bandhauer]

jst: Is there anything here that matters besides the nsSidebar.js errors? If not
then just dup it against bug 99808. I'll put a patch there and maybe someone
will actually check it in.

Comment 2

[John Bandhauer]

*** Bug 114981 has been marked as a duplicate of this bug. ***

Comment 3

[John Bandhauer]

Attachment: This will fix it. Let's get this checked in. As discussd in bug 99808

Comment 4

[John Bandhauer]

sgehani: I'll twist jst's arm to sr= this. If you could review it and check it
in when the tree opens for 0.9.8 then maybe we can avoid spending any more time
on the dups of this bug that keep trickling in. Thanks.

Comment 5

[John Bandhauer]

FWIW, I meant to refer to bug 105814 when I posted the patch above.

Comment 6

[Samir Gehani]

Comment on attachment 61603 [details] [diff] [review]
This will fix it. Let's get this checked in. As discussd in bug 99808

r=sgehani  Thanks.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 61603 [details] [diff] [review]
This will fix it. Let's get this checked in. As discussd in bug 99808

sr=jst

Comment 8

[Johnny Stenback (:jst)]

*** Bug 105814 has been marked as a duplicate of this bug. ***

Comment 9

[Samir Gehani]

*** Bug 117366 has been marked as a duplicate of this bug. ***

Comment 10

[Samir Gehani]

Sure, mozilla0.9.8.

Comment 11

[Fabian Guisset]

*** Bug 117457 has been marked as a duplicate of this bug. ***

Comment 12

[Fabian Guisset]

The number of dups is getting bad, please check this in asap, thanks.

Comment 13

[timeless]

fix checked in

Comment 14

[sujay]

intalled all 3 tabs from that site...installed fine w/o JS errors in console.

verified in 2/13 build.