Bug 1112740 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

Julien Wajsberg [:julienw] (PTO -> Mar 16)

on 2015-01-05 23:25:02 PST

(Hidden by Administrator)

Revision 1 by

David Lawrence [:dkl]

on 2015-08-24 13:33:40 PDT

Hi, awalgarg, thanks, looks good !

Can you try to add a test in test/font_fit_test.js ?
I don't see how to do it otherwise than calling directly _getStyleProperties with a heading having a bogus fontFamily. If this don't work, please keep it in the pull request and ask me so that I can have a look :)

You have information about how to run tests in [1].

In case you use Linux, I personally need to add "FIREFOX_NIGHTLY_BIN=/path/to/firefox" before "npm test" so that it correctly picks up my Firefox Nightly, but if you use MacOS X I think it works automatically.

[1] https://github.com/gaia-components/gaia-header/#tests

Thanks !