Hi, sorry for the delay. Yes, please merge your commits. Our workflow is that we have one revision per reviewable chunk of code, and this case is certainly simple enough for one revision. (If a bug is big and requires many different loosely copuple parts, then we'll often split that up into multiple revisions.) Depending on your personal workflow, you can make as many commits locally as you like, but when requesting review, and when posting new versions of your work due to review comments, please squash them somehow and post a single revision. In this case, it looks like you can merge your D51505 into D51504 and then send D51504 to Phabricator again.
Bug 1391239 Comment 25 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Hi, sorry for the delay. Yes, please merge your commits. Our workflow is that we have one revision per reviewable chunk of code, and this case is certainly simple enough for one revision. (If a bug is big and requires many different loosely coupled parts, then we'll often split that up into multiple revisions.) Depending on your personal workflow, you can make as many commits locally as you like, but when requesting review, and when posting new versions of your work due to review comments, please squash them somehow and post a single revision. In this case, it looks like you can merge your D51505 into D51504 and then send D51504 to Phabricator again.