:mstange, my changes for bug 1641372 potentially result in a change in behavior here and I wanted to see your thoughts. There's more info in https://github.com/mozsearch/mozsearch/pull/408 but the summary is: - The existing https://searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has all of the overloaded superclass results you didn't want - The new https://asuth.searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has just the 1 result grouped by "Definitions (nsDisplayOutline::CreateWebRenderCommands)" because we don't walk up the superclass / overrides automatically. Would you only want the new behavior in this case, or would you want some combination of: - Showing the parent override (but not all of its other overrides) - In a separate group, so we have "Definitions (nsDisplayItem::CreateWebRenderCommands)" in addition to the existing "Definitions (nsDisplayOutline::CreateWebRenderCommands)" - By having the group header have some interactive pieces like "Definitions (nsDisplayItem::CreateWebRenderCommands, `[ ]` nsDisplayItem::CreateWebRenderCommands, `[ ]` nsDisplayItem::CreateWebRenderCommands overrides)" - Optionally showing all of those other overrides, possibly via a search upsell link that is just an entirely new search - Something else!
Bug 1466692 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
:mstange, my changes for bug 1641372 potentially result in a change in behavior here and I wanted to see your thoughts. There's more info in https://github.com/mozsearch/mozsearch/pull/408 but the summary is: - The existing https://searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has all of the overloaded superclass/overrides results you didn't want - The new https://asuth.searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has just the 1 result grouped by "Definitions (nsDisplayOutline::CreateWebRenderCommands)" because we don't walk up the superclass / overrides automatically. Would you only want the new behavior in this case, or would you want some combination of: - Showing the parent override (but not all of its other overrides) - In a separate group, so we have "Definitions (nsDisplayItem::CreateWebRenderCommands)" in addition to the existing "Definitions (nsDisplayOutline::CreateWebRenderCommands)" - By having the group header have some interactive pieces like "Definitions (nsDisplayItem::CreateWebRenderCommands, `[ ]` nsDisplayItem::CreateWebRenderCommands, `[ ]` nsDisplayItem::CreateWebRenderCommands overrides)" - Optionally showing all of those other overrides, possibly via a search upsell link that is just an entirely new search - Something else!
:mstange, my changes for bug 1641372 potentially result in a change in behavior here and I wanted to see your thoughts. There's more info in https://github.com/mozsearch/mozsearch/pull/408 but the summary is: - The existing https://searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has all of the overloaded superclass/overrides results you didn't want - The new https://asuth.searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has just the 1 result grouped by "Definitions (nsDisplayOutline::CreateWebRenderCommands)" because we don't walk up the superclass / overrides automatically. Would you only want the new behavior in this case, or would you want some combination of: - Showing the parent override (but not all of its other overrides) - In a separate group, so we have "Definitions (nsDisplayItem::CreateWebRenderCommands)" in addition to the existing "Definitions (nsDisplayOutline::CreateWebRenderCommands)" - By having the group header have some interactive pieces like "Definitions (`[ ]` nsDisplayOutline::CreateWebRenderCommands, `[ ]` overridden nsDisplayItem::CreateWebRenderCommands, `[ ]` nsDisplayItem::CreateWebRenderCommands overrides)" - Optionally showing all of those other overrides, possibly via a search upsell link that is just an entirely new search - Something else!
:mstange, my changes for bug 1641372 potentially result in a change in behavior here and I wanted to see your thoughts. There's more info in https://github.com/mozsearch/mozsearch/pull/408 but the summary is: - The existing https://searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has all of the overloaded superclass/overrides results you didn't want - The new https://asuth.searchfox.org/mozilla-central/search?q=nsdisplayoutline%3A%3Acreat&path= has just the 1 result grouped by "Definitions (nsDisplayOutline::CreateWebRenderCommands)" because we don't walk up the superclass / overrides automatically. Would you only want the new behavior in this case, or would you want some combination of: - Showing the parent override (but not all of its other overrides) - In a separate group, so we have "Definitions (nsDisplayItem::CreateWebRenderCommands)" in addition to the existing "Definitions (nsDisplayOutline::CreateWebRenderCommands)" - By having the group header have some interactive pieces like "Definitions (`[x]` nsDisplayOutline::CreateWebRenderCommands, `[ ]` overridden nsDisplayItem::CreateWebRenderCommands, `[ ]` nsDisplayItem::CreateWebRenderCommands overrides)" - Optionally showing all of those other overrides, possibly via a search upsell link that is just an entirely new search - Something else!