Review of attachment 9057060 [details] [diff] [review]: ----------------------------------------------------------------- The 'mach gtest TestMsgStripRE*' did work in the end, after I renamed the functions SetACookie(), xSetACookieNoHttp(), xInitPrefs() in TestMailCookie.cpp as those functions also exist in a m-c test file. It seems building gtests packs all test files together into a common namespace so duplicate function names must not exist. At least in my build on Linux with gcc. ::: mailnews/base/test/TestMsgStripRE.cpp @@ +1,5 @@ > /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ > /* This Source Code Form is subject to the terms of the Mozilla Public > * License, v. 2.0. If a copy of the MPL was not distributed with this > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > +#include "TestCommon.h" Blank line before first include. But actually having this include made the build of the test fail so please remove it if possible.
Bug 1466748 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Review of attachment 9057060 [details] [diff] [review]: ----------------------------------------------------------------- The 'mach gtest TestMsgStripRE*' did work in the end, after I renamed the functions SetACookie(), SetACookieNoHttp(), InitPrefs() in TestMailCookie.cpp as those functions also exist in a m-c test file. It seems building gtests packs all test files together into a common namespace so duplicate function names must not exist. At least in my build on Linux with gcc. ::: mailnews/base/test/TestMsgStripRE.cpp @@ +1,5 @@ > /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ > /* This Source Code Form is subject to the terms of the Mozilla Public > * License, v. 2.0. If a copy of the MPL was not distributed with this > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > +#include "TestCommon.h" Blank line before first include. But actually having this include made the build of the test fail so please remove it if possible.