1466748 - Resurrect TestMsgStripRE.cpp

Status: RESOLVED FIXED

(MailNews Core :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Attachment: 1466343-TestMsgStripRE.patch (v2) - from bug 1466343

+++ This bug was initially created as a clone of Bug #1466343 +++

Patch attached, note bug 1466343 comment #12 ...
  The test needs to be changed since after decoding we 
  always re-encode in UTF-8, yet the test, which must 
  pre-date JS Mime, expects the original charset.

... and bug 1466343 comment #19 for review comments.

We also need to work out how to run the test, see bug 1466343 comment #10.

Comment 1

[Jorg K (CEST = GMT+2)]

Also see bug 1320861 for another case of wanting to run a gTest. Actually mach gtest TestMailCookie* does something, but the test fails. I'll take a look what's going on.

Comment 2

[Jorg K (CEST = GMT+2)]

Hmm, same for mach gtest TestMsgStripRE*.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1466748-TestMsgStripRE.patch (v3)

This passes now. I'll get this landed and then file a new bug to make gTests run as part of the test suite.

Comment 4

[Jorg K (CEST = GMT+2)]

Hmm, Aceman doesn't see to have much fun with mach gtest TestMsgStripRE*, so let's check whether it builds at least:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=12ee1a167a34deb85332401839813bc2636ecde6

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1466748-TestMsgStripRE.patch (v3b)

Removed include to fix Aceman's compile issues.

Comment 6

[:aceman]

Comment on attachment 9057060 [details] [diff] [review]
1466748-TestMsgStripRE.patch (v3)

Review of attachment 9057060 [details] [diff] [review]:
-----------------------------------------------------------------

The 'mach gtest TestMsgStripRE*' did work in the end, after I renamed the functions SetACookie(), SetACookieNoHttp(), InitPrefs() in TestMailCookie.cpp as those functions also exist in a m-c test file. It seems building gtests packs all test files together into a common namespace so duplicate function names must not exist. At least in my build on Linux with gcc.

::: mailnews/base/test/TestMsgStripRE.cpp
@@ +1,5 @@
>  /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +#include "TestCommon.h"

Blank line before first include.

But actually having this include made the build of the test fail so please remove it if possible.

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1466748-TestMsgStripRE.patch (v3c)

OK, this should now build for Aceman. Also hitting the cookie test here.

Comment 8

[:aceman]

Comment on attachment 9057097 [details] [diff] [review]
1466748-TestMsgStripRE.patch (v3c)

Review of attachment 9057097 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, TestMsgStripRE.cpp now builds and passes for me. Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/efb59254daa2
fix TestMsgStripRE.cpp. r=aceman