Bug 1470510 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Apparently Thunderbird doesn't compile with your changes, see bug 1593469 comment #3:

/home/magnus/Code/tb/mozilla/dom/base/nsGlobalWindowOuter.h:465:32: error: member access into incomplete type 'mozilla::dom::BrowsingContext'
return GetBrowsingContext()->HadOriginalOpener();

Could you please check that you haven't forgotten an include file somewhere.
Revision 1 by
on 
Apparently Thunderbird doesn't compile with your changes, see bug 1593469 comment #3:

33:29.13 In file included from c:/mozilla-source/comm-central/xpfe/appshell/AppWindow.cpp:23:
33:29.13 c:/mozilla-source/comm-central/dom/base\nsGlobalWindowOuter.h(465,32): error: member access into incomplete type 'mozilla::dom::BrowsingContext'
33:29.13     return GetBrowsingContext()->HadOriginalOpener();
33:29.13                                ^
33:29.13 c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include\nsIWindowProvider.h(22,7): note: forward declaration of 'mozilla::dom::BrowsingContext'
33:29.13 class BrowsingContext; /* webidl BrowsingContext */
33:29.13       ^

Could you please check that you haven't forgotten an include file somewhere.
Revision 2 by
on 
Apparently Thunderbird doesn't compile with your changes, see bug 1593469 comment #3:

EDIT: I compiled it myself and got:
33:29.13 In file included from c:/mozilla-source/comm-central/xpfe/appshell/AppWindow.cpp:23:
33:29.13 c:/mozilla-source/comm-central/dom/base\nsGlobalWindowOuter.h(465,32): error: member access into incomplete type 'mozilla::dom::BrowsingContext'
33:29.13     return GetBrowsingContext()->HadOriginalOpener();
33:29.13                                ^
33:29.13 c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include\nsIWindowProvider.h(22,7): note: forward declaration of 'mozilla::dom::BrowsingContext'
33:29.13 class BrowsingContext; /* webidl BrowsingContext */
33:29.13       ^

Could you please check that you haven't forgotten an include file somewhere.

Back to Bug 1470510 Comment 7