Spawned from https://github.com/mozilla/devtools-adb-extension/pull/15 We are currently very strict in the list of platforms supported for ADB. There is a json file in the addon that describes which platform should use which binaries: https://github.com/mozilla/devtools-adb-extension/blob/dac824a0c556e857c5a3df03c82b1259aafdf641/extension/adb.json ``` { "Linux": { "x86": [ "linux/adb" ], "x86_64": [ "linux64/adb" ] }, "Darwin": { "x86_64": [ "mac64/adb" ] }, "WINNT": { "x86": [ "win32/adb.exe", "win32/AdbWinApi.dll", "win32/AdbWinUsbApi.dll" ], "x86_64": [ "win32/adb.exe", "win32/AdbWinApi.dll", "win32/AdbWinUsbApi.dll" ] } } ``` And we expect the strings above (WINNT, x86_64,....) to match exactly the information we get about the current OS when we unpack ADB: https://searchfox.org/mozilla-central/rev/330daedbeac2bba296d663668e0e0cf248bc6823/devtools/shared/adb/adb-binary.js#119-121
Bug 1522149 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Spawned from https://github.com/mozilla/devtools-adb-extension/pull/15 We are currently very strict in the list of platforms supported for ADB. There is a json file in the addon that describes which platform should use which binaries: https://github.com/mozilla/devtools-adb-extension/blob/dac824a0c556e857c5a3df03c82b1259aafdf641/extension/adb.json ``` { "Linux": { "x86": [ "linux/adb" ], "x86_64": [ "linux64/adb" ] }, "Darwin": { "x86_64": [ "mac64/adb" ] }, "WINNT": { "x86": [ "win32/adb.exe", "win32/AdbWinApi.dll", "win32/AdbWinUsbApi.dll" ], "x86_64": [ "win32/adb.exe", "win32/AdbWinApi.dll", "win32/AdbWinUsbApi.dll" ] } } ``` And we expect the strings above (WINNT, x86_64,....) to match exactly the information we get about the current OS when we unpack ADB: https://searchfox.org/mozilla-central/rev/330daedbeac2bba296d663668e0e0cf248bc6823/devtools/shared/adb/adb-binary.js#119-121 However in practice we have 4 flavors of the binaries: linux32, linux64, macos and windows. The addon should probably still describe which binaries are available, but there should be a mapping logic in our devtools module. We should be able to say "windows" and "aarch64" ? -> use the windows binary ; without hardcoding new mappings in the addon.