Bug 1534455 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Just to give an update of this bug:
* This depends on the removal of `legacy-urlbar` (the current patch the breaks the old urlbar) and possibly autocomplete-rich-result-popup (not sure it's really needed but it will get removed together with `legacy-urlbar` anyway)
* Tests/reftests need to be ported with the new markup (`<html:input is="autocomplete-input"/>` instead of `<textbox type="autocomplete"/>`) and possibly new selectors

There are also some `XXX(ntim)` comments in the patch:
* One regarding comment 5
* One regarding bug 1556566 (although just wrapping the searchbar.js usage with `<moz-input-box>` would also do the job without needing to fix bug 1556566)
* `clickSelectsAll` needs to ported, this is pretty easy, see bug 1558574
Revision 1 by
on 
Just to give an update of this bug:
* This depends on the removal of `legacy-urlbar` (the current patch breaks the old urlbar) and possibly autocomplete-rich-result-popup (not sure it's really needed but it will get removed together with `legacy-urlbar` anyway)
* Tests/reftests need to be ported with the new markup (`<html:input is="autocomplete-input"/>` instead of `<textbox type="autocomplete"/>`) and possibly new selectors

There are also some `XXX(ntim)` comments in the patch:
* One regarding comment 5
* One regarding bug 1556566 (although just wrapping the searchbar.js usage with `<moz-input-box>` would also do the job without needing to fix bug 1556566)
* `clickSelectsAll` needs to ported, this is pretty easy, see bug 1558574
Revision 2 by
on 
Just to give an update of this bug:
* This depends on the removal of `legacy-urlbar` (the current patch breaks the old urlbar) and possibly autocomplete-rich-result-popup (not sure it's really needed but it will get removed together with `legacy-urlbar` anyway)
* Tests/reftests need to be ported with the new markup (`<html:input is="autocomplete-input"/>` instead of `<textbox type="autocomplete"/>`) and possibly new selectors

There are also some `XXX(ntim)` comments in the patch:
* One regarding comment 5
* One regarding bug 1556566 (although just wrapping the searchbar.js usage with `<moz-input-box>` would also do the job without needing to fix bug 1556566)
* ~~`clickSelectsAll` needs to ported, this is pretty easy, see bug 1558574~~ bug 1528614 is getting rid of `clickSelectsAll`
Revision 3 by
on 
Just to give an update of this bug:
* This depends on the removal of `legacy-urlbar` (the current patch breaks the old urlbar) and possibly autocomplete-rich-result-popup (not sure it's really needed but it will get removed together with `legacy-urlbar` anyway)
* Tests/reftests need to be ported with the new markup (`<html:input is="autocomplete-input"/>` instead of `<textbox type="autocomplete"/>`) and possibly new selectors

There are also some `XXX(ntim)` comments in the patch:
* One regarding comment 5
* One regarding bug 1556566 (although just wrapping the searchbar.js usage with `<moz-input-box>` would also do the job without needing to fix bug 1556566)
* ~~`clickSelectsAll` needs to ported, this is pretty easy, see bug 1558574~~. Bug 1528614 is getting rid of `clickSelectsAll`

Back to Bug 1534455 Comment 6