Thanks for the submission! I worry that warn-on-implicit-enable will cause false-positives on most existing content. I think the most helpful we can be here is to watch for *usage* of implicitly enabled functionality. For example, FormatUsageInfo::renderable[1] could become an enum or class that tracks if it was enabled implicitly or explicitly. Then, when we perform validation against it, we can generate warnings if it wasn't explicitly enabled. We also need to be sure that if a user later explicitly enables an extension, we update our implicit/explicit tracking, so that we don't force them to activate extensions in a particular order.
Bug 1535809 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks for the submission! I worry that warn-on-implicit-enable will cause false-positives on most existing content. I think the most helpful we can be here is to watch for *usage* of implicitly enabled functionality. For example, FormatUsageInfo::renderable[1] could become an enum or class that tracks if it was enabled implicitly or explicitly. Then, when we perform validation against it, we can generate warnings if it wasn't explicitly enabled. We also need to be sure that if a user later explicitly enables an extension, we update our implicit/explicit tracking, so that we don't force them to activate extensions in a particular order. [1]: https://searchfox.org/mozilla-central/source/dom/canvas/WebGLFormats.h#316
Thanks for the submission! I worry that warn-on-implicit-enable will cause false-positives on most existing content. I think the most helpful we can be here is to watch for *usage* of implicitly enabled functionality. For example, [FormatUsageInfo::renderable] could become an enum or class that tracks if it was enabled implicitly or explicitly. Then, when we perform validation against it, we can generate warnings if it wasn't explicitly enabled. We also need to be sure that if a user later explicitly enables an extension, we update our implicit/explicit tracking, so that we don't force them to activate extensions in a particular order. [FormatUsageInfo::renderable]: https://searchfox.org/mozilla-central/source/dom/canvas/WebGLFormats.h#316