1535809 - Warn when implicitly-enabled extensions are used

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P2)

Description

[Kelsey Gilbert [:jgilbert]]

This will help prevent devs from shipping non-portable code.

Comment 1

[Greyson Gilbert]

Attachment: Bug 1535809 - Add warning for implicit extensions.

Emits a warning when an extension is enabled implicitly.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Thanks for the submission!

I worry that warn-on-implicit-enable will cause false-positives on most existing content.
I think the most helpful we can be here is to watch for usage of implicitly enabled functionality.

For example, FormatUsageInfo::renderable could become an enum or class that tracks if it was enabled implicitly or explicitly. Then, when we perform validation against it, we can generate warnings if it wasn't explicitly enabled.

We also need to be sure that if a user later explicitly enables an extension, we update our implicit/explicit tracking, so that we don't force them to activate extensions in a particular order.

Comment 3

[Greyson Gilbert]

Attachment: Bug 1535809 - Add warning on use of implicitly enabled extensions

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d8406bfe056
Add warning on use of implicitly enabled extensions r=jgilbert

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5d8406bfe056