Bug 1537729 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Review of attachment 9090062 [details] [diff] [review]:
-----------------------------------------------------------------

From and subject are now close to each other, but then there is extra vertical space before To. 
But there's some more serious problem. Try with a small window, and the form and to fields (well the whole rows) are painted on top of each other.

::: mail/base/content/msgHdrView.js
@@ +901,5 @@
> +      if (!headerEntry.valid) {
> +        headerEntry.enclosingRow.setAttribute("hidden", "hidden");
> +      } else {
> +        headerEntry.enclosingRow.removeAttribute("hidden");
> +      }

headerEntry.enclosingRow.toggleAttribute("hidden", !headerEntry.valid);

@@ +953,1 @@
>      }

headerEntry.enclosingRow.toggleAttribute("hidden", !headerEntry.valid)
Revision 1 by
on 
Review of attachment 9090062 [details] [diff] [review]:
-----------------------------------------------------------------

From and subject are now close to each other, but then there is extra vertical space before To. 
But there's some more serious problem. Try with a small window, and the from and to fields (well the whole rows) are painted on top of each other.

::: mail/base/content/msgHdrView.js
@@ +901,5 @@
> +      if (!headerEntry.valid) {
> +        headerEntry.enclosingRow.setAttribute("hidden", "hidden");
> +      } else {
> +        headerEntry.enclosingRow.removeAttribute("hidden");
> +      }

headerEntry.enclosingRow.toggleAttribute("hidden", !headerEntry.valid);

@@ +953,1 @@
>      }

headerEntry.enclosingRow.toggleAttribute("hidden", !headerEntry.valid)

Back to Bug 1537729 Comment 5