Bug 1553474 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: The users will not be able to bookmark a page when they long press on an item from Top Sites grid view, because only "Remove bookmark" option is displayed even if the page is not bookmarked.
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: 1. Navigate to a Recommended by Pocket page;
    2. Go back to the about:home page;
    3. Long tap on that page from the Top Sites grid view;
    4. Pay attention to the "Bookmark" option from the Context Menu.

Expected result:
Page is not bookmarked.

Actual result:
"Remove bookmark" option is displayed.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The changes are not risky because we did only some small changes, such as adding a condition to check the value of a column.
* **String changes made/needed**: No strings were added.
Revision 1 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: The users will not be able to bookmark a page when they long press on an item from Top Sites grid view, because only "Remove bookmark" option is displayed even if the page is not bookmarked.
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: 
    1. Navigate to a Recommended by Pocket page;
    2. Go back to the about:home page;
    3. Long tap on that page from the Top Sites grid view;
    4. Pay attention to the "Bookmark" option from the Context Menu.

Expected result:
Page is not bookmarked.

Actual result:
"Remove bookmark" option is displayed.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The changes are not risky because we did only some small changes, such as adding a condition to check the value of a column.
* **String changes made/needed**: No strings were added.

Back to Bug 1553474 Comment 6