Bug 1567622 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Hmm, OK, so `_handleTrrPrefsReady` is a promise and not a function. It's set here:
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#80
but if you read the comment above, there are some tricks to initialise the UI "later". Looks like when we get to
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#349
it hasn't been initialised for some reason.

Looks like other parts dealing with `uiReady` are missing from C-C:
https://searchfox.org/comm-central/search?q=uiReady&case=false&regexp=false&path=

Especially this one here:
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mozilla/browser/components/preferences/in-content/tests/browser_connection_dnsoverhttps.js#85
Revision 1 by
on 
Hmm, OK, so `_handleTrrPrefsReady` is a promise and not a function. It's set here:
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#80
but if you read the comment above, there are some tricks to initialise the UI "later". Looks like when we get to
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#349
it hasn't been initialised for some reason.

Looks like other parts dealing with `uiReady` are missing from C-C:
https://searchfox.org/comm-central/search?q=uiReady&case=false&regexp=false&path=

Especially this one here:
https://searchfox.org/mozilla-central/rev/96403eac4ff6f96f89a0b120b29bd46540d5705e/browser/components/preferences/in-content/tests/browser_connection_dnsoverhttps.js#85
Revision 2 by
on 
Hmm, OK, so `_handleTrrPrefsReady` is a promise and not a function. It's set here:
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#80
but if you read the comment above, there are some tricks to initialise the UI "later". Looks like when we get to
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#349
it hasn't been initialised for some reason.

Looks like other parts dealing with `uiReady` are missing from C-C:
https://searchfox.org/comm-central/search?q=uiReady&case=false&regexp=false&path=

Especially this one here:
https://searchfox.org/mozilla-central/rev/96403eac4ff6f96f89a0b120b29bd46540d5705e/browser/components/preferences/in-content/tests/browser_connection_dnsoverhttps.js#85

EDIT: Scrap that, that's in a test.
Revision 3 by
on 
Hmm, OK, so `_handleTrrPrefsReady` is a promise and not a function. It's set here:
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#80
but if you read the comment above, there are some tricks to initialise the UI "later". Looks like when we get to
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#349
it hasn't been initialised for some reason.

~~Looks like other parts dealing with `uiReady` are missing from C-C:
https://searchfox.org/comm-central/search?q=uiReady&case=false&regexp=false&path=~~

~~Especially this one here:
https://searchfox.org/mozilla-central/rev/96403eac4ff6f96f89a0b120b29bd46540d5705e/browser/components/preferences/in-content/tests/browser_connection_dnsoverhttps.js#85~~

EDIT: Scrap that, that's in a test.

Back to Bug 1567622 Comment 4