1567622 - "Use provider" menulist in Connection Settings empty

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Richard Marti (:Paenglab)]

In prefs / General / Connection when opening the dialog through "Settings…", the "Use provider" menulist at the bottom is empty. In the console is:

TypeError: this._handleTrrPrefsReady is not a function connection.js:349:12

Comment 1

[Richard Marti (:Paenglab)]

I don't see what is wrong. Every help is welcome.

Comment 2

[Jorg K (CEST = GMT+2)]

Does this work in FF Nightly?

https://searchfox.org/comm-central/search?q=_handleTrrPrefsReady&path=

I can't see a function by the name of _handleTrrPrefsReady anywhere. Looks broken.

Comment 3

[Richard Marti (:Paenglab)]

It works in Nightly. I think, this has to do something with the promise gConnectionsDialog.uiReady = new Promise(resolve => {}.

Comment 4

[Jorg K (CEST = GMT+2)]

Hmm, OK, so _handleTrrPrefsReady is a promise and not a function. It's set here:
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#80
but if you read the comment above, there are some tricks to initialise the UI "later". Looks like when we get to
https://searchfox.org/comm-central/rev/4502bdd72571ebece25b9f4fc8a2d7a3292db0b2/mail/components/preferences/connection.js#349
it hasn't been initialised for some reason.

Looks like other parts dealing with uiReady are missing from C-C:
https://searchfox.org/comm-central/search?q=uiReady&case=false&regexp=false&path=

Especially this one here:
https://searchfox.org/mozilla-central/rev/96403eac4ff6f96f89a0b120b29bd46540d5705e/browser/components/preferences/in-content/tests/browser_connection_dnsoverhttps.js#85

EDIT: Scrap that, that's in a test.

Comment 5

[Jorg K (CEST = GMT+2)]

Diffing connection.js from M-C and C-C shows quite some differences, most of them related to the "prettier" reformatting in M-C. But I also spotted some stuff we haven't ported yet:
https://hg.mozilla.org/mozilla-central/rev/d426669c4cba#l14.37
Or maybe we have:
https://hg.mozilla.org/comm-central/rev/2f5aab4c8902#l9.13

In any case, this looks like a regression from bug 1562560.

Comment 6

[Jorg K (CEST = GMT+2)]

Working it TB 69, so that confirms the regression.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1567622-init-network-prefs-1.diff

Looks like we're doing things out-of-order.

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9079890 [details] [diff] [review]
1567622-init-network-prefs-1.diff

Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/41c462c6bdfa
Initialise connection preferences dialog in the right order. r=Paenglab