Bug 1569588 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Looks like `JobModel.retrigger(jobs, repoName, notify, times)` is the main API we have to use.
Basically, we only need to know the perf jobs we want to retrigger & their repository.

One weird thing I see: it appears `repoName` is not used inside this static method. :camd why is that? Could I just remove this parameter from this function signature?
Revision 1 by
on 
Looks like `JobModel.retrigger(jobs, repoName, notify, times)` is the main API we have to use.
Basically, we only need to know the perf jobs we want to retrigger & their repository.

One weird thing I see: it appears `repoName` is not used inside this static method. :camd why is that? Could I just remove this parameter from this function signature?

This findings should suffice reusing this functionality on FE.
Revision 2 by
on 
Looks like `JobModel.retrigger(jobs, repoName, notify, times)` is the main API we have to use.
Basically, we only need to know the perf jobs we want to retrigger & their repository.
This findings should suffice reusing this functionality on FE.

One weird thing I see: it appears `repoName` is not used inside this static method. :camd why is that? Could I just remove this parameter from this function signature?

Back to Bug 1569588 Comment 1