I just realized one potential issue https://hg.mozilla.org/mozilla-central/diff/e8257acd87021bc4c61013c439547e9740c21c91/browser/locales/en-US/browser/menubar.ftl Why this menu doesn't have an accesskey? Is it expected? If it needs fixing, it needs to land ASAP, otherwise I need to ask for a backout. Side note: is it expected to land these patches without front-end review? The second one in this bug landed only with my review on record, and that's definitely not OK.
Bug 1570569 Comment 7 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I just realized one potential issue https://hg.mozilla.org/mozilla-central/diff/e8257acd87021bc4c61013c439547e9740c21c91/browser/locales/en-US/browser/menubar.ftl Why this menu doesn't have an accesskey? Is it expected? If it needs fixing, it needs to land ASAP: I can block exposing other strings for localization, otherwise it will need to land with a new ID to fix it. The alternative is asking for a backout. Side note: is it expected to land these patches without front-end review? The second one in this bug landed only with my review on record, and that's definitely not OK.
I just realized one potential issue https://hg.mozilla.org/mozilla-central/diff/e8257acd87021bc4c61013c439547e9740c21c91/browser/locales/en-US/browser/menubar.ftl Why this menu doesn't have an accesskey? Is it expected? If it needs fixing, it needs to land ASAP: I can block exposing other strings for localization for a few hours, otherwise it will need to land with a new ID to fix it. The alternative is asking for a backout. Side note: is it expected to land these patches without front-end review? The second one in this bug landed only with my review on record, and that's definitely not OK.