1570569 - Update synced-tabs menu and sidebar to reflect the decoupling of FxA and Sync

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, enhancement)

Description

[Ryan Kelly [:rfkelly]]

Per Bug 1570565, we aim to decouple "Signing in to Firefox" from "Enabling Firefox Sync". The various synced-tabs UI touchpoints will need to be updated to reflect three main potential states:

• The user is not signed in to Firefox
• The user is signed in to Firefox, but has not enabled Firefox Sync
• The user is signed in to Firefox and is syncing their data

We have (at least) the following touchpoints:

• Synced tabs submenu under FxA toolbar menu
• Synced tabs submenu under hamburger menu
• Synced tabs sidebar

I believe the first action here is to get to finalized UX designs.

Comment 1

[Ana Medinac]

Another touchpoint that we might have:

• Synced Tabs submenu under 'View history, saved bookmarks, and more' menu

Comment 2

[Edouard Oger [:eoger]]

Work to do:

• Handle offline state
• Handle sync OFF state.

Ref: https://docs.google.com/document/d/1HivpoRdZBrt-59lLuU9dJPsTrn95hOvgCpFjVouk6IM/edit#heading=h.pt3v3lbp6emi

Comment 3

[Edouard Oger [:eoger]]

Attachment: Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu.

Comment 4

[Edouard Oger [:eoger]]

Attachment: Bug 1570569 p2 - Add Sync Disabled state to Synced Tabs sidebar.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8257acd8702
p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh
https://hg.mozilla.org/integration/autoland/rev/e2c6e425c67f
p2 - Add Sync Disabled state to Synced Tabs sidebar. r=fluent-reviewers,flod

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e8257acd8702
https://hg.mozilla.org/mozilla-central/rev/e2c6e425c67f

Comment 7

[Francesco Lodolo [:flod]]

I just realized one potential issue
https://hg.mozilla.org/mozilla-central/diff/e8257acd87021bc4c61013c439547e9740c21c91/browser/locales/en-US/browser/menubar.ftl

Why this menu doesn't have an accesskey? Is it expected? If it needs fixing, it needs to land ASAP: I can block exposing other strings for localization for a few hours, otherwise it will need to land with a new ID to fix it. The alternative is asking for a backout.

Side note: is it expected to land these patches without front-end review? The second one in this bug landed only with my review on record, and that's definitely not OK.

Comment 8

[Johann Hofmann [:johannh]]

Side note: is it expected to land these patches without front-end review? The second one in this bug landed only with my review on record, and that's definitely not OK.

No, this should probably be backed out for not having a reviewer, IMO.

Mark/Edouard, can you take a look at this, please?

Comment 9

[Vijay Budhram]

:johannh sorry about that, this was actually an r+ with nits. The issue noted as been fixed so this is good to go!

Comment 10

[Edouard Oger [:eoger]]

Why this menu doesn't have an accesskey? Is it expected? If it needs fixing, it needs to land ASAP: I can block exposing other strings for localization for a few hours, otherwise it will need to land with a new ID to fix it. The alternative is asking for a backout.

I don't mind making a new string ID, do you have an access key suggestion?

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Edouard Oger [:eoger] from comment #10)

Why this menu doesn't have an accesskey? Is it expected? If it needs fixing, it needs to land ASAP: I can block exposing other strings for localization for a few hours, otherwise it will need to land with a new ID to fix it. The alternative is asking for a backout.

I don't mind making a new string ID, do you have an access key suggestion?

So, it does need an accesskey? From a quick look at the tools menu, It looks like n is free, but you should double check with an actual English build.

Note that I do mind changing the ID, because we would be asking folks to translate the same label twice within a few days. If the fix lands before EOD, I can hold on with updating strings, but not for several days.

Comment 12

[Vasilica Tamas, QA [:vtamas]]

Tested on Firefox 71.0b7 under Windows 10 64-bit and Mac OS X 10.14.6 around all 3 areas (FxA toolbar menu, Synced tabs submenu under hamburger menu, Synced tabs sidebar) and here are the results:

• The user is not signed in to Firefox
  • Synced Tabs submenu - “Sign in to Sync...” button
  • Synced Tab sidebar - “Sign in to Sync” button
  • Send tab - “Sign in to Firefox” button
• The user is signed in to Firefox, but has not enabled Firefox Sync
  • Synced Tabs submenu - “Turn on Sync...” button
  • Synced Tab sidebar - “Turn on Sync” button
  • Send tab - the available devices are displayed
• The user is signed in to Firefox and is syncing their data
  • Synced Tabs submenu - synced tabs are displayed
  • Synced Tab sidebar - synced tabs are displayed
  • Send tab - the available devices are displayed

Also a new issue was encountered during this testing and was filed to be tracked separately: Bug 1594666.

Based on the above mentioned I am marking this bug as Verified.