Bug 1580728 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

There are two existing context menu actions (for the request list) related to request blocking.

- Block URL
- Unblock URL

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#309-325

And related Redux Actions objects:
https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/actions/requests.js#108-134

They are currently sending the URL to the backend, which is responsible for the actual request blocking.

New functionality:

- Block URL: should open the `Request blocking` side panel and add the URL into the list
- Unblock URL: should remove the URL from the list and open the `Request blocking` side panel.

Honza
This bug should connect the new Request Blocking UI with the backend.

There are two existing context menu actions (for the request list) related to request blocking.

- Block URL
- Unblock URL

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#309-325

And related Redux Actions objects:
https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/actions/requests.js#108-134

They are currently sending the URL to the backend, which is responsible for the actual request blocking.

New functionality:

- Block URL: should open the `Request blocking` side panel and add the URL into the list
- Unblock URL: should remove the URL from the list and open the `Request blocking` side panel.

Actions responsible for modifying the `RequestBlockingReducer` should also be responsible for updating the backend. Alternativelly we could use a new `RequestBlockingMiddleware` if that would make things more clean.

The backend connector has already two request-blocking API. We can reuse them or introduce new if needed.

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/connector/firefox-connector.js#291-307

Honza

Back to Bug 1580728 Comment 0