Closed Bug 1580728 Opened 5 months ago Closed 5 months ago

Connect Request Blocking UI with the backend

Categories

(DevTools :: Netmonitor, enhancement, P3)

All
Unspecified
enhancement

Tracking

(firefox71 verified)

VERIFIED FIXED
Firefox 71
Tracking Status
firefox71 --- verified

People

(Reporter: Honza, Assigned: davidwalsh)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [debugger-mvp])

Attachments

(1 file)

This bug should connect the new Request Blocking UI with the backend.

There are two existing context menu actions (for the request list) related to request blocking.

  • Block URL
  • Unblock URL

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#309-325

And related Redux Actions objects:
https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/actions/requests.js#108-134

They are currently sending the URL to the backend, which is responsible for the actual request blocking.

New functionality:

  • Block URL: should open the Request blocking side panel and add the URL into the list
  • Unblock URL: should remove the URL from the list and open the Request blocking side panel.

Actions responsible for modifying the RequestBlockingReducer should also be responsible for updating the backend. Alternativelly we could use a new RequestBlockingMiddleware if that would make things more clean.

The backend connector has already two request-blocking API. We can reuse them or introduce new if needed.

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/connector/firefox-connector.js#291-307

Honza

Summary: Context menu support for blocking specific requests → Connect Request Blocking UI with the backend
Component: Debugger → Netmonitor
Blocks: dbg-71
Whiteboard: [debugger-mvp]
Assignee: nobody → dwalsh
Status: NEW → ASSIGNED
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e741a14aa7f9
Wire up backend of blocked URLs r=Honza
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Updating status.

Status: RESOLVED → VERIFIED
QA Contact: cristian.fogel
Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.