1580728 - Connect Request Blocking UI with the backend

Status: VERIFIED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This bug should connect the new Request Blocking UI with the backend.

There are two existing context menu actions (for the request list) related to request blocking.

• Block URL
• Unblock URL

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#309-325

And related Redux Actions objects:
https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/actions/requests.js#108-134

They are currently sending the URL to the backend, which is responsible for the actual request blocking.

New functionality:

• Block URL: should open the Request blocking side panel and add the URL into the list
• Unblock URL: should remove the URL from the list and open the Request blocking side panel.

Actions responsible for modifying the RequestBlockingReducer should also be responsible for updating the backend. Alternativelly we could use a new RequestBlockingMiddleware if that would make things more clean.

The backend connector has already two request-blocking API. We can reuse them or introduce new if needed.

https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/connector/firefox-connector.js#291-307

Honza

Comment 1

[David Walsh :davidwalsh]

Attachment: Bug 1580728 - Wire up backend of blocked URLs r=honza

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e741a14aa7f9
Wire up backend of blocked URLs r=Honza

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e741a14aa7f9

Comment 4

[Cristian Fogel [:cfogel]]

Updating status.