Bug 1593018 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: Potential revenue loss from non intended sponsored content dismissal.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: [Prerequisites]:

    Have the following preferences set:
    browser.search.region to US
    browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
    browser.newtabpage.activity-stream.discoverystream.enabled to true
    browser.newtabpage.activity-stream.discoverystream.endpoints to https://,http://
    browser.newtabpage.activity-stream.discoverystream.config to
    {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://5ad1b408-b40a-4a49-b6ec-27473d192df0.mock.pstmn.io"}

[Steps to reproduce]:

    Open the browser with the profile from the prerequisites.
    Open a new tab.
    Click the Context Menu button from any top site.
    Click on the Dismiss button.
    Observe the Sponsored Top Site and Text Promo section.

[Expected result]:

    The Sponsored Top Site and Text Promo section are still displayed.

[Actual result]:

    The Sponsored Top Site and Text Promo section are no longer displayed.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: It's 1 line and been verified and was caused by a regression (so it was, before the regression, already shipped)
* **String changes made/needed**: none
Revision 1 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: Potential revenue loss from non intended sponsored content dismissal.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: 
[Prerequisites]:

    Have the following preferences set:
    browser.search.region to US
    browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
    browser.newtabpage.activity-stream.discoverystream.enabled to true
    browser.newtabpage.activity-stream.discoverystream.endpoints to https://,http://
    browser.newtabpage.activity-stream.discoverystream.config to
    {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://5ad1b408-b40a-4a49-b6ec-27473d192df0.mock.pstmn.io"}

[Steps to reproduce]:

    Open the browser with the profile from the prerequisites.
    Open a new tab.
    Click the Context Menu button from any top site.
    Click on the Dismiss button.
    Observe the Sponsored Top Site and Text Promo section.

[Expected result]:

    The Sponsored Top Site and Text Promo section are still displayed.

[Actual result]:

    The Sponsored Top Site and Text Promo section are no longer displayed.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: It's 1 line and been verified and was caused by a regression (so it was, before the regression, already shipped)
* **String changes made/needed**: none
Revision 2 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: Potential revenue loss from non intended sponsored content dismissal.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: 
[Prerequisites]:

    Have the following preferences set:
    browser.search.region to US
    browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
    browser.newtabpage.activity-stream.discoverystream.enabled to true
    browser.newtabpage.activity-stream.discoverystream.endpoints to https://,http://
    browser.newtabpage.activity-stream.discoverystream.config to
   {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://5ad1b408-b40a-4a49-b6ec-27473d192df0.mock.pstmn.io"}

[Steps to reproduce]:
    Open the browser with the profile from the prerequisites.
    Open a new tab.
    Click the Context Menu button from any top site.
    Click on the Dismiss button.
    Observe the Sponsored Top Site and Text Promo section.
[Expected result]:
    The Sponsored Top Site and Text Promo section are still displayed.
[Actual result]:
    The Sponsored Top Site and Text Promo section are no longer displayed.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: It's 1 line and been verified and was caused by a regression (so it was, before the regression, already shipped)
* **String changes made/needed**: none

Back to Bug 1593018 Comment 13